Comments (2)
kaymen99
commented on May 18, 2024
[fix] I added a new function that allow user to get all listing
from contracts.
nkrishang
commented on May 18, 2024
Hey y'all 👋🏽
We're working on the next iteration of the Marketplace contract; you can track the effort, here: #259
We've added explicit view functions such as getAllListings and getAllValidListings that'll be included in this next iteration of the Marketplace contract: https://github.com/thirdweb-dev/contracts/blob/marketplace-v3/contracts/marketplace/direct-listings/DirectListingsLogic.sol#L301-L367
These view functions are not present in the current version of the Marketplace contract due to the contract crossing the smart contract size limit (~24.576 kb) on adding such view functions.
from contracts.
Related Issues (20)
- Unable to manually verify source code on block explorer. HOT 1
- optimizations HOT 7
- ERC721AVirtualApproveUpgradeable => Identifier not found or not unique => AddressData HOT 1
- Managed Smart Wallet contracts fail to Truffle compile: "lib/dynamic-contracts" not found HOT 6
- Suggestion HOT 1
- out of gas error HOT 1
- deploy bug HOT 3
- [Question] Extending marketplace permission HOT 1
- getAllProposals for vote contract fails to return data HOT 3
- Missing benchmarks for multiple contracts HOT 1
- Add test & gas benchmark for Marketplace contract to gasreport.txt HOT 2
- Custom Tokens Not Deducted on NFT Claim HOT 1
- Issue with deploy and login during the new device authentication step HOT 3
- Staking721Upgradeable - _calculateRewards out of gas problem HOT 1
- Deposit Reward Tokens (depositRewardTokens) area has a problem. HOT 3
- npx thirdweb create contract HOT 2
- TCP error when running `forge build` on the `contracts` repo HOT 3
- ZKsync deploy HOT 3
- Revoke signature on zk by revoke HOT 1
- Fix token deploy contract HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from contracts.