Giter Club home page Giter Club logo

Comments (4)

thibaultcha avatar thibaultcha commented on August 20, 2024

Oh yes indeed! It seems like a good idea. Instead of a patch, I will accept a pull request (we're on GitHub after all) but if you don't implement it, I will, so no worries :).
About the code you posted, I think we can factorize it a bit to have a unique NSError object wich can be instanced by an HTTP error or a "notEnoughFreeDiskSpace" error, if error != nil, we'll call the block and/or the delegate method. What do you think?

Thank you for the suggestion 👍

from tcblobdownload.

hirnschmalz avatar hirnschmalz commented on August 20, 2024

This sounds great to me. I'm very 'new' here at GitHub, but I will try my best with the pull request :)

from tcblobdownload.

thibaultcha avatar thibaultcha commented on August 20, 2024

This is very simple, and SO powerful, you'll see :)

To do a pull request:

  • Start by forking the project on wich you want to work: grey button top right corner of the screen where you are in a project. This will copy the repo to your profile.
  • Do your modifs on it. Whetever you want, it's yours.
  • When finished, click the green button with two arrows on the top left (of your forked project or the original project)

Write a summary of your changes and send it! The owner of the repo (or a collaborator) will review your changes and deiced wether they should be merged or not to the main project.

It's a very powerful tool combining git merging and the social aspect of GitHub :)

from tcblobdownload.

thibaultcha avatar thibaultcha commented on August 20, 2024

Fixed by PR #3

from tcblobdownload.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.