Giter Club home page Giter Club logo

Comments (4)

JustinCappos avatar JustinCappos commented on May 24, 2024

It likely isn't. Let's address it.

from python-tuf.

vladimir-v-diaz avatar vladimir-v-diaz commented on May 24, 2024

TKK: Since you are currently working on modules related to this, you would be the ideal person to scrutinize/test the implementation for this attack.
Excluding code from the test and interposition modules, we only read data from a remote source in 'download.py'. We make a urllib2 connection to retrieve metadata and target files.
https://github.com/akonst/tuf/blob/master/tuf/download.py#L198
I believe we are vulnerable to a slow retrieval attack in 'download.py'. This is difficult to solve or protect against without a tradeoff.

Resources:
http://docs.python.org/2/library/urllib2.html#urllib2.urlopen
http://www.velocityreviews.com/forums/t720616-urllib2-urlopen-and-read-difference.html

from python-tuf.

trishankkarthik avatar trishankkarthik commented on May 24, 2024

Let me discuss this with Justin tomorrow; I have an idea that might work.

from python-tuf.

trishankkarthik avatar trishankkarthik commented on May 24, 2024

Fixed with the recent refactoring changes to the downloaded and updater modules, which will be in at least a1132af and onwards.

from python-tuf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.