Comments (2)
Here is the complete fix. With this, the critical section will be unlocked for all code paths that can exit the method:
class LockCriticalSection
{
public:
LockCriticalSection(CRITICAL_SECTION& sect)
: sect_(sect)
{
EnterCriticalSection(§_);
}
~LockCriticalSection()
{
LeaveCriticalSection(§_);
}
private:
CRITICAL_SECTION& sect_;
};
void MidiInWinMM :: closePort( void )
{
if ( connected_ ) {
WinMidiData *data = static_cast<WinMidiData *> (apiData_);
LockCriticalSection lock( data->_mutex );
midiInReset( data->inHandle );
midiInStop( data->inHandle );
for ( size_t i=0; i < data->sysexBuffer.size(); ++i ) {
int result = midiInUnprepareHeader(data->inHandle, data->sysexBuffer[i], sizeof(MIDIHDR));
delete [] data->sysexBuffer[i]->lpData;
delete [] data->sysexBuffer[i];
if ( result != MMSYSERR_NOERROR ) {
midiInClose( data->inHandle );
data->inHandle = 0;
errorString_ = "MidiInWinMM::openPort: error closing Windows MM MIDI input port (midiInUnprepareHeader).";
error( RtMidiError::DRIVER_ERROR, errorString_ );
return;
}
}
midiInClose( data->inHandle );
data->inHandle = 0;
connected_ = false;
}
}
from rtmidi.
I think I may have been observing the subsequent deadlock that will occur by not leaving the cs here.
Shouldn't it also close the port and do the rest of the cleanup (e.g. set connected false)? In other words, perhaps the fix can simply be replacing the early return with a break
.
from rtmidi.
Related Issues (20)
- Need help on the RtMidi library implementation in Visual Studio Code HOT 1
- Question: how do I add WEB_MIDI_API to my cmake subfolder file?
- RtMidi cannot create ports past a certain limit HOT 10
- iOS status and how-to HOT 4
- Central List of Wrapper Libraries / Projects Using RtMidi?
- Does rtmidi support midi 2.0? HOT 16
- How to detect, that a MIDI-IN is already used by another app? HOT 4
- Compilation error HOT 1
- Checksum change for rtmidi-6.0.0.tar.gz HOT 2
- rtmidi doesn't find jack in a non standard path. (Or the default pipewire path)
- Note On with velocity 0 is sent as Note Off on macOS HOT 9
- Has the uploaded release been changed intentionally? HOT 1
- Cmake version requirement
- Can't send over RTMIDI_API_WINDOWS_MM HOT 2
- Needs Better Install Tutorial HOT 3
- configure: error: No known system type found for MIDI support!
- are Virtual Ports supported under Windows HOT 4
- midiOutUnprepareHeader intermittently hangs on Windows during repeated large sysex sends HOT 1
- Different MIDI device names on different platforms HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rtmidi.