Missing metadata occasionally about flac2all HOT 4 CLOSED

Hmm, I will have to investigate this further. I remember adding the 
"--block-number 2" to it because that is where the metadata was stored on all 
the test files I used. I don't want to fix this bug and break it for everyone 
else :)

Right, removing "--block-number 2" is not a long term fix, because the other 
blocks may confuse the metadata parser. 

Also, block number 2 seems to be the default block used for Vorbis comments by 
the reference FLAC encoder, but from what I see there is no requirements for 
this to be fixed. As long as the block type is "VORBIS COMMENT" it is valid. 
Could be that other encoders don't put it in that block.

Either way, a better way of detecting Vorbis comment blocks will be needed. 

Fair enough and thanks. Looking at http://xiph.org/flac/format.html suggests 
that the STREAMINFO metadata block must be the first metadata block, followed 
by zero or more other metadata blocks, in no particular order. That certainly 
mirrors what I've seen with the different versions of flac encoders over the 
years.

I've attached a patch so that the scanner only starts looking for comment tags 
within a "Type 4 Vorbis Comment" metablock. That will prevent comment tags in 
other metablock types from poisoning the track tags. This is my first foray 
into Python so if the code looks amateurish, that's because it is!

Thank you very much for the code patch! I have integrated it into the current 
stable version. Please can you check out revision 37 and make sure it works ( I 
will do the same in the coming days as well).