Comments (1)
Hello!
The SH code in this project originally came from many years ago when we were first doing experiments at work. I can't quite remember the circumstances, but we ended up performing simple transformation on the XYZ components to account for differences in our coordinate system compared to what was used in some of the papers we were reading through. Either way we ended up negating X and Y, and when you propagate that through the polynomials you get the code that's in this repository, I believe that this is okay as long as you're careful to be consistent and do the same transformation everywhere, which is why there's no visual errors in the sample. However I think for publicly-released code it would probably be best to fix the polynomials so that they match the literature, which would make it less confusing. It would also be good for anyone that wanted to extend the code further, since they would probably be thrown off by the coordinate transformation.
Either way, I really appreciate you pointing this out. It's all too easy for things like this to unnoticed, and end up forgotten over the years. When I get some time I'll go through the code and fix the SH polynomials, but until then I'll leave this open.
from bakinglab.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bakinglab.