Giter Club home page Giter Club logo

Comments (2)

judgej avatar judgej commented on June 26, 2024

I think isRedirect() needs to be made conditional, just like isSuccessful() is in the same class:

https://github.com/thephpleague/omnipay-authorizenet/blob/master/src/Message/SIMCompleteAuthorizeResponse.php#L60

That shouldn't break anything, because people shouldn't be redirecting when there is no reason to redirect anyway, so I'm assuming this change would not hit any working code.

That's assuming this isn't just all a mistake, and there should never be a redirect at this point in the SIM protocol? Need to check the docs to clarify that. It's a deprecated protocol, so has limited life anyway - people should be moving off it.

from omnipay-authorizenet.

lukeholder avatar lukeholder commented on June 26, 2024

We have gotten around this just by treating SIM differently. It just meant we couldn't treat it like all other gateways. Due to our changes SIM is now working for us, so I will leave it to you to decide to update omnipay.

Thanks @judgej

from omnipay-authorizenet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.