Giter Club home page Giter Club logo

Comments (7)

philipobenito avatar philipobenito commented on September 2, 2024 1

@XedinUnknown very good catch, and I'm not sure how this works either, it must fallback from the alias if there isn't a clash. Will test that out later to see if it's the case

from container.

philipobenito avatar philipobenito commented on September 2, 2024

This requires no action in regard to container interop as a composer update will bring in the change. However there will be a breaking change update to depend directly on PSR-11 some time in the near future.

from container.

hannesvdvreken avatar hannesvdvreken commented on September 2, 2024

@philipobenito correct me if I'm wrong but... you can just add a implements PsrContainerInterface, no? It's just a new minor version. Look at this PR to Symfony to see what I mean:

symfony/symfony#21265

Cheers

from container.

philipobenito avatar philipobenito commented on September 2, 2024

@hannesvdvreken Correct but I have some other BC changes planned so makes sense to all come together and remove the middleman dependency.

from container.

hannesvdvreken avatar hannesvdvreken commented on September 2, 2024

Ah, I see. Didn't know stuff was about to change.

But are you open for small incremental steps to allow PSR-11 now? Instead of holding it off until rewrite is ready?

Seen #123? just asking.

from container.

philipobenito avatar philipobenito commented on September 2, 2024

Just Looking :-)

from container.

XedinUnknown avatar XedinUnknown commented on September 2, 2024

The temporary interface Interop/Container/ContainerInterface extends the PSR-11 interface, so anything that allows the temp interface allows the standard, as well, and this doesn't seem to be a problem.

What does seem to be a problem, however, is League\Container\Container, or more precisely its definition. It says that the container implements some ContainerInterface, but this name is not imported. There does not appear to be a League\Container\ContainerInterface, and the interop container is aliased to InteropContainerInterface, so I'm not sure how this code works.

from container.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.