Can't use extend with factory closures about container HOT 8 CLOSED

Hmm, I dunno, let me think on it for a day or so (a little busy today), my initial thoughts are that it's not a major change over my example above. Having reminded myself of the codebase, it would be fine as an addition to AbstractDefinition, we'd just need to add it to the interface on the next major version bump. I'm just not 100% sure on the semantics yet.

from container.

If I understand what you're trying to do then extend should already be able to do this?

from container.

No, because in the case of a factory closure, extend returns a CallableDefinition and it does not have any method that allows me to add another closure to extend it like in ClassDefinition with withMethodCall.

To resolve this problem, I can add a withCallback method to AbstractDefinition, I just want your opinion before I start working on it.

from container.

@nebulousGirl ah, I see what you mean. You could do this, seems a little like a work around but I think safer overall than enabling withMethodCall.

$container
    ->add('something', function ($methods = []) {
        $service = new Service;

        foreach ($methods as $method => $args) {
            call_user_func_array([$service, $method], $args);
            // you could even go a little further here and have the container resolve $args
        }

        return $service;
    })
;

$container->get('something'); // no methods invoked as none passed to the callable

$container
    ->extend('something')
    ->withArgument(new RawArgument([
        'methodName' => [/* args */],
        'anotherMethod' => [/* args */]
    ])
;

$container->get('something'); // methodName and anotherMethod both invoked

from container.

@nebulousGirl the problem with adding a method to AbstractDefinition is that it's flirting with a BC break if we want to keep interfaces up to date.

from container.

Would you prefer that I create a trait that is used both by CallableDefinition and ClassDefinition?

from container.

Any news on this one? Trying to make a decorator to support service-providers but I'm being blocked by the same issue :/

from container.

This is handled by 421d774 for release in 3.0.0.

You can now add method calls to any definition and it will attempt to invoke those methods if the end concrete is an object.

from container.