Yan-C-Bin duplicate about dnd-monster-api HOT 5 CLOSED

@BrianWendt hey! sorry for the late reply!

Thanks for flagging. I'll check to see what's going on. Maybe just an artifact of duplicate runs or changing data. If 729 is more complete then maybe removing 761 makes the most sense.

from dnd-monster-api.

Hmm so it seems the original source has changed their format for their monster descriptions (it actually makes it easier to parse).

However, there are some duplicates in the original data too that will definitely transfer to this project.

Until a new parser can be built to handle the new format, unfortunately we're going to have to live with the duplicates in this dataset. :(

from dnd-monster-api.

How often are you re-parsing?
I've not looked at the parser code itself, just the results, but maybe there could be a post process that detects duplicates and flags them for review.
I'll try taking a look later.

from dnd-monster-api.

I haven't parsed in a while. It's a very manual process. you have to literally checkout the code, run yarn build-db and the git commit/push back to master.

The parser isn't built very well, it's very fast and completely coupled to the structure of the repository that it get's content from. That structure just changed. We're going to have stale data until a new parser can be built.

A post process for detecting duplicates sounds pretty nice! would be pretty cool to have.

from dnd-monster-api.

gonna close this issue for now because the parser has been rewritten to be able to pull latest from the source.

We can revisit this if it's a problem in the future.

from dnd-monster-api.