Giter Club home page Giter Club logo

Comments (11)

csinchok avatar csinchok commented on August 9, 2024

This actually should support wrappers just fine. We use this functionality from time to time ourselves. To see an example, just plug the url http://videoads.theonion.com/vast/224.xml into our test player at http://theonion.github.io/videojs-vast-plugin/.

Have you already tried this with wrappers, and have run into issues? If so, let's us know what you're seeing, and we can certainly look into it.

from videojs-vast-plugin.

ponchorage avatar ponchorage commented on August 9, 2024

In the call to vast.client.get it is returning undefined as the value for the response in the callback. I can see that the VAST XML document is getting called. Here is an example ad tag that we are using: http://ad.doubleclick.net/pfadx/ddm.kslm/ReaderApp;sz=1x1000;pos=player;tile=1;ord=1396381165?

from videojs-vast-plugin.

ponchorage avatar ponchorage commented on August 9, 2024

I tried your wrapper XML file and it worked fine. I'm also on DFP so maybe that is the problem?

from videojs-vast-plugin.

csinchok avatar csinchok commented on August 9, 2024

Hey, I tried your URL, and it worked at first, but now isn't serving an XML file. Could you provide some static sample files demonstrating the problem? Because I think your DFP URL expired, perhaps.

from videojs-vast-plugin.

ponchorage avatar ponchorage commented on August 9, 2024

Well, seems to be working. It was just that the ad server (DFP) kept wanting to send me Flash ads.

from videojs-vast-plugin.

snizemic avatar snizemic commented on August 9, 2024

I am trying to get to work this plugin with DFP but I am still unsuccessful :-( My tag from DFP doesn't even work on test player but it works in other test players, eg. jwplayer. Should it work in video.js with videojs-vast-plugin or I am trying the impossible. I feel sorrowful. I will be grateful for any advice.

from videojs-vast-plugin.

csinchok avatar csinchok commented on August 9, 2024

Hey @snizemic, do you have some kind of example code somewhere? Or some kind of detail on the errors you're seeing? Without that, this is pretty difficult to diagnose.

from videojs-vast-plugin.

snizemic avatar snizemic commented on August 9, 2024

Hi, thanks for quick reply. Here is my tag from DFP. It works here but it does not here.

from videojs-vast-plugin.

csinchok avatar csinchok commented on August 9, 2024

The problem has nothing to do with wrappers, so this is the wrong ticket. I have opened up issue #33 for this.

The issue here (if you look at the network requests) is that the test player is requesting the VAST file twice, and DFP does this really fun thing where subsequent requests with the same "correlator" value lead to an empty file. So, on the second request, DFP returns an empty file, the player says "ok, well then I guess I'll just play the video".

I'm not sure why the sample player does this, as our on-site player do not, so I would recommend that for the time being, you try this out on your own, outside of the test player.

from videojs-vast-plugin.

snizemic avatar snizemic commented on August 9, 2024

Thanks for your time and information!

from videojs-vast-plugin.

saketsoni avatar saketsoni commented on August 9, 2024

Hello,

Regarding this reply
"The issue here (if you look at the network requests) is that the test player is requesting the VAST file twice, and DFP does this really fun thing where subsequent requests with the same "correlator" value lead to an empty file. So, on the second request, DFP returns an empty file, the player says "ok, well then I guess I'll just play the video"."

Please let me know if there is a solution to this.

According to this page: https://support.google.com/dfp_premium/answer/1068325?hl=en
"A random number, typically the timestamp of the page view, that's shared by multiple requests coming from the same page view. If you're not using the Google IMA SDK, see note below.* Correlator is used to implement competitive exclusions, including in cookieless environments."

Thank you

from videojs-vast-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.