Comments (3)
I've recently worked on updating them and a lot of the checkboxes under Pull Request Requirements are different on each of the repos.
Yeah I just looked and they diverge a lot more than I remember; that probably puts a PR template out of the question then (mostly caused by all of the exercise repo's have you included the <insert solution variant>
in your changes)
from top-meta.
It is a good idea to centralize what we can, but I do not think we can use one PULL_REQUEST_TEMPLATE.md
for all of the repositories.
I've recently worked on updating them and a lot of the checkboxes under Pull Request Requirements are different on each of the repos. For example, the suggested title of the PR is different on a lot of the repos. On the main site, we ask for tests to be written for new features. On exercise repos we also ask for solutions to be updated.
If we consolidated them, we would need a lot of checkboxes with wording like "If applicable..." and I think contributors would get lost on knowing if it is applicable.
from top-meta.
So I had some free time today, and came up with this. yes
means that the file matched the standard file, when comparing against the ones in theodinproject
repo, as I assume thats where they got copied from. Almost none of the PR templates match; except for one minor difference most of issue templates do match (also if someone has the free time to check my work I'd greatly appreciate it; I think I got them all correct but its entirely possible I missed something)
Repo | Is there a PR template? | PR | Is there a Issues folder? | feature_request | bug_report |
---|---|---|---|---|---|
curriculum | yes | no | yes | no | no |
theodinproject | yes | no | yes | yes | yes |
top-meta | no | N/A | yes | no | no |
odin-bot-v2 | yes | no | yes | no | yes |
react-examples | yes | no | yes | yes** | yes** |
javascript-exercises | yes | no | yes | yes** | yes** |
css-exercises | yes | no | yes | yes** | yes** |
ruby_testing | yes | no | yes | yes** | yes** |
blog | yes | no* | no | N/A | N/A |
ruby-exercises | yes | no | yes | yes** | yes** |
custom_enumerable_project | yes | yes | no | N/A | N/A |
.github*** |
* Only contains note on spellchecker; set up code-spell?
** Only difference is the example location****; can probably be dropped as long as the checkbox remains?
*** N/A: Intended Default
**** By this I mean that they contain some variation on the following line - [ ] The title of this issue follows the location for request: brief description of request format, e.g. <repo specific location>: <sometimes repo specific example
. This is the only piece of information I think could be safely dropped by generalizing to just - [ ] The title of this issue follows the location for request: brief description of request format
from top-meta.
Related Issues (20)
- Lesson: More on State
- Lesson: How to deal with side effects HOT 1
- Lesson: Project CV Application HOT 3
- Lesson: Project Memory Card HOT 1
- Lesson: Project Shopping Cart HOT 2
- Section: React and the Backend
- Lesson: Using Ruby on Rails For Your Backend
- Lesson: Using NodeJS For Your Backend
- Lesson: Project Where's Waldo (A Photo Tagging App)
- Lesson: Project Messaging App
- Lesson: Refs and Memoization HOT 1
- Lesson: Introduction to React Testing HOT 2
- Lesson: Mocking Callbacks and Components HOT 1
- Lesson (update): Update Setting up a React Environment lesson to use Vite
- Restructure TOP-meta repo HOT 9
- Add a Conclusion lesson to the JavaScript course HOT 2
- Admin V2 HOT 2
- Move all community guides to top-meta HOT 2
- Projects - extra credit section
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from top-meta.