Comments (3)
Thanks @JustWaveThings, this is a great point!
I'm leaning towards always going back to the start when the sort is changed. I can see some benefit in maintaining your position in the list within the pagination. But going back to the start seems like it would be more useful with the sort options we make available.
I wouldn't mind getting some third and fourth opinions about it before going ahead though aha.
Extra
It won't be hard to do - we're handling the params for the sort here. If pagination has been used, the page param will be implicitly merged into the selected sort params and sent over the wire together. If we want the sort to always go back to the start, we can do that by explicitly overriding the page param with page: 1
as one of the params.
from theodinproject.
@KevinMulhern I think it would make more sense to jump to page 1 whenever a sorting change is made by the user too. Because whenever users change the sorting rule, they are definitely expecting to view the data from page 1 again. (At least in my case!)
from theodinproject.
I am sorry I did't catch this when you were looking for people to review it.
from theodinproject.
Related Issues (20)
- Bug: Progress badge overlapping modals HOT 1
- Bug: Layout shift when closing modals on small screens HOT 1
- Bug: Markdown preview tool does not render dropdowns and summaries HOT 2
- Bug: Markdown preview doesn't work with <details> tag HOT 3
- Suggestion: Change links to 'unvisited' once a lesson has been unmarked as complete HOT 3
- Add “Continue” button and badge for selected path HOT 10
- Bug: EJS syntax highlighting not supported HOT 1
- Chore: Additional Prism language support HOT 2
- Feature Request: Level 4 headings render h4 > a with fragment (and id) HOT 9
- Chore: Wiki/Reflections from a Rails-newcomer HOT 5
- Feature Request: Link the markdown preview tool somewhere in the website itself
- Bug: <outdated hyperlinks of faq page> HOT 3
- Add Feature Flag HOT 1
- UI: draft requirements HOT 2
- Backend: Draft Requirements
- Database: Draft Requirements
- Backend: Get wordlist for predefined options
- Frontend: learn enough about Stimulus to use 'Slim Select' for the multi-select
- Next lesson button doesn't lead to the beginning of the next lesson. HOT 4
- Bug: Broken link HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from theodinproject.