themindvirus / cc-modded Goto Github PK

Connecting Loops of Networking Cable or Full Wired Modems (as shown below) causes the player's machine to crawl to a halt.

On Servers this slows down the game to a point where it kicks all connected players and in some rare cases even causes the Host Machine to run out of memory, crash and reboot. This is a somewhat known issue with the host mod, "CC:Tweaked",
which has not been patched in "CC:Modded".

The known workaround to this issue is to just not place any loops of networking cable where possible
and to use opposite sides of a computer or peripheral to connect modems to prevent the cable from joining and looping.

This is similar to real world scenarios where network loops can cause recoverable lag spikes due to recursion and conflicts.
A Time-To-Live could be imposed for network traffic, such as the TTL of 12 set by OpenComputers Networks.

ProjectRed's Fabrication and RedPower2's Coloured Lamps are missing from 1.18.2 and were ported from 1.7.10 to 1.12.2.
Too Many Items became Not Enough Items which became Just Enough Items (and for 1.18.2 it requires the Configured mod).

RedNet Cable from MineFactory Reloaded (and Bundled Cable) is also missing from 1.18.2 but was present since 1.7.10.
Iron Chests' Crystal Chest would be a good addition to ComputerCraft in general as a place to visibly store backup floppy disks.

The id change worked but the name is still picked up as the type from remote computers.
This is somewhat desirable as it doesn't break programs that use it and lets you change the id.
However, it would be logical to refer to the device by both "<name_id>" and "<type_id>".

id changes only apply after a reboot of the remote computer and newly placed modems default to "null" in the HashMap
which is a form of incoherent caching that has remained consistently maintained without change for several years.
Potential solutions are to leave it as it is with its current behaviour or make a new alpha version with propagated changes.

1. Fix curseforge liscence to reflect the CC Lisence
2. rebase all of this as an actual, proper fork of CC:T,

First thing, Wrong licensing, You have it set to MIT the correct licensing would be ccpl.

Second, please make new screenshots I can't see very well with nighttime screenshots due to your textures being darker colours.

And in your comment's you mention this being a fork of cc:tweaked however you do not mention this anywhere else. Unless you count one line saying "CC:TWEAKED Tweaked some more." It would be good to have a link to tweaked as well.

Finally, please use Github's release feature instead of having a build folder.

The original documentation states that Command Computers shall not boot startup.lua automatically from disk drive.
Original Documentation: https://computercraft.info/wiki/Command_Computer

This causes problems when commanding them using remote procedure call programs over the network with inconsistencies.
Modems are also not allowed to call functions remotely on the computers without remote procedure call programs over rednet
which never start because the boot program was never called for cluster units in device firmware upgrade (DFU) mode.

The temporary solution is to allow Command Computers to boot automatically from the most local disk drive as normal.

The more permanent solution is to make a new type of computer called the Cluster Computer which has the new textures and is configured to allow calling methods over the network from new types of device called Router and Switch.

A Cluster Computer is built on top of a Command Computer to allow startup disk booting and calling methods using Modems.

A Switch is built on top of a Wired Modem to allow calling methods on Computers with peripheral.call(...).

A Router is built on top of a Switch and adds a built-in Computer to configure the Firewall to filter messages from any source.

A Wireless Router is built on top of a Router to allow Computers with Wireless Modems to connect in Infrastructure Mode.

Configuration options to enable the usage of the newly proposed blocks should be added
but not to toggle the presence of the block itself as this would cause world loading errors.

This should be an actual fork of CC:T, instead of copy/pasted code.
That way if new features are added in CC:T, it can be easily added here.

Also CC:T is CCPL licenced, not MIT, and it is illegal to relicence it as anything other than CCPL.