Disable focus after openning a dialog about react-focus-lock HOT 15 CLOSED

@theKashey not sure that I describe it correctly, maybe I describe it better in Telegram :D

from react-focus-lock.

This is somehow related toallowTextSelection prop (#10). This option just allow "not" to have an active element in the lock.
It does not disable autofocus, but you can blur by your self.

https://codesandbox.io/s/oj01rx089y

from react-focus-lock.

Awesome. Thanks!

from react-focus-lock.

Should we change docs?

from react-focus-lock.

Should we change a prop name? :)

from react-focus-lock.

Even more - should it be a single prop, or two?

• shouldHaveFocus, about allowing not to have a focused element. Maybe disabled by default.
• nofocus(autofocus=false?), about just blurring the active one on lock activation. As long you (usually) have to press some button to open something with a Lock, so the goal is to remove focus from "not Lock", but not had in Lock.

Proper naming always were a problem.

from react-focus-lock.

I like this plan 👍 especially autobluring :)

from react-focus-lock.

Ok, lets flip a coin - nofocus=true/autofocus=false ?

from react-focus-lock.

autofocus is not very clear because it looks like related with autofocus attribute.

Maybe initialFocus: true|false?

from react-focus-lock.

For me initialFocus sounds like a focus "target", not the behaviour.

from react-focus-lock.

focusOnStart?

from react-focus-lock.

focusOnLock then, or noautofocus, looseFocus, blurred, dontFocus. Meh 💩
I should ask my real english mates.

from react-focus-lock.

They proposed autoFocus=false as a best property name.
The bad thing - currently allowTextSelection disables that autofocus, and letting you not have a focus inside, doing all the things in a same time, and has to be refactored.

from react-focus-lock.

@ai - v1.7.0 just got shipped.
See https://github.com/theKashey/react-focus-lock/releases/tag/1.7.0 for details.
PS: just <FocusLock autoFocus={false}>....

from react-focus-lock.

Thanks :) Everything works

from react-focus-lock.