Comments (4)
Are you talking about encapsulating the $_SERVER
and $_SESSSION
variables?
If so, why don't we just use the symfony/http-foundation
package? The ::createFromGlobals()
method allows you to easily wrap up and read the request data, and also modify responses before sending them back. Things like adding headers etc gets a bit easier.
from tki.
I have suspected for a while that the project will end up using Symfony, but I'm not quite ready to make that jump. I think for the specific requirements of this bug, we can craft a reasonable small class that can manage our needs without additional overhead.
To answer your question, while POST & GET are also useful to encapsulate, SERVER and SESSION are the main concerns. I would probably start with those, and see where things land before moving to the rest. Server especially has some tricky security implications. So yes, those two are the focus (at least for this specific bug).
from tki.
That's understandable. My only counter to that is that you don't have to use the whole thing, you could just pull in symfony/http-foundation
and only use it's Request
class. But I do also understand why you want to minimise these things. sounds like a solid plan!
from tki.
Halfway done! Symfony's http-foundation component did the trick for the $_SERVER side of the equation (save one entry I have to figure out in classes/Compress). More testing to do, but so far, looks great! Thanks again, @jakecleary !!
from tki.
Related Issues (20)
- All SQL calls should have logging
- All PDO SQL calls should use named parameter binding
- Session security improvement - user agent
- What are your plans for the codebase? HOT 5
- Should we use PDO datatype Constants in queries using bindParams (and bindValues)? HOT 2
- Config file/DB and languages / localization ideas HOT 1
- JQuery or other JavaScript library or framework? HOT 4
- Track composer support for web-install alternative to composer install
- setup_info.php cookie test fails HOT 1
- setup_info.php smarty path test fails HOT 1
- Beacons need a revamp
- New Scheduler
- Create universe on step 30 with existing install triggers errors HOT 1
- Add strict typing to all files
- Eliminate die() in class files (replace with try/catch and thrown exceptions) HOT 1
- Better "lack of SSL" error handling
- All PDO fetch calls need to specify the fetch style/type
- Add extension loaded check HOT 1
- lost files HOT 3
- Lrscan erorrs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tki.