Comments (4)
Note that your NullSauceTunnel could be way simpler if you just extend NullTunnel and copy over the sendJobState function from SauceLabsTunnel:
var NullTunnel = require('digdug/NullTunnel');
var SauceLabsTunnel = require('digdug/SauceLabsTunnel');
function NullSauceTunnel() {
NullTunnel.apply(this, arguments);
}
NullSauceTunnel.prototype = Object.create(NullTunnel.prototype);
NullSauceTunnel.prototype.constructor = NullSauceTunnel;
NullSauceTunnel.prototype.sendJobState = SauceLabsTunnel.prototype.sendJobState;
module.exports = NullSauceTunnel;
from digdug.
We don’t have any plans to separate the service reporting part from the tunnel any time in the foreseeable future, but if this is important to you please do send a patch and it can be added.
from digdug.
Actually my code in NullSauceTunnel cannot be currently simplified due to proxy issues. (I'm using different request library)
from digdug.
Closing this due to inactivity, and because the core issue (that there were proxy issues with the SauceLabsTunnel) is really what should be addressed. We can re-open this in the Intern tracker if it's still a desirable feature.
from digdug.
Related Issues (20)
- Can't override webdriver version in SeleniumTunnel
- Java requirement and SeleniumTunnel HOT 3
- Update BrowserStack binary support HOT 1
- Verbose flag does not work with Selenium 3.5.x+ HOT 2
- Verbose mode breaks with Selenium 3.5.0 HOT 5
- Switch to Intern 4 for self tests
- Add Edge support to SeleniumTunnel
- chromedriver.exe stays running after tunnel stops HOT 2
- Chrome 65 support needs to to be released HOT 10
- Failed to start tunnel - null or selenium tunnel HOT 3
- edge or MicrosoftEdge or ? HOT 2
- Downloading Selenium and Drivers via HTTPS through Proxy fails HOT 7
- Update WebDriver versions in dig dug HOT 1
- Include processor arch in tunnel binary directory
- regression in digdug 2.2.4 HOT 11
- Support for Edge Chromium
- SessionNotCreatedException: session not created: This version of ChromeDriver only supports Chrome version 74 HOT 1
- Class 'Tunnel' incorrectly implements interface 'Url' HOT 15
- Update webdriver versions HOT 3
- Ctrl-C leaves process running HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from digdug.