Giter Club home page Giter Club logo

Comments (4)

csnover avatar csnover commented on June 23, 2024

Note that your NullSauceTunnel could be way simpler if you just extend NullTunnel and copy over the sendJobState function from SauceLabsTunnel:

var NullTunnel = require('digdug/NullTunnel');
var SauceLabsTunnel = require('digdug/SauceLabsTunnel');

function NullSauceTunnel() {
  NullTunnel.apply(this, arguments);
}
NullSauceTunnel.prototype = Object.create(NullTunnel.prototype);
NullSauceTunnel.prototype.constructor = NullSauceTunnel;
NullSauceTunnel.prototype.sendJobState = SauceLabsTunnel.prototype.sendJobState;
module.exports = NullSauceTunnel;

from digdug.

csnover avatar csnover commented on June 23, 2024

We don’t have any plans to separate the service reporting part from the tunnel any time in the foreseeable future, but if this is important to you please do send a patch and it can be added.

from digdug.

bartoszkaczorek avatar bartoszkaczorek commented on June 23, 2024

Actually my code in NullSauceTunnel cannot be currently simplified due to proxy issues. (I'm using different request library)

from digdug.

jason0x43 avatar jason0x43 commented on June 23, 2024

Closing this due to inactivity, and because the core issue (that there were proxy issues with the SauceLabsTunnel) is really what should be addressed. We can re-open this in the Intern tracker if it's still a desirable feature.

from digdug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.