Giter Club home page Giter Club logo

Comments (8)

csnover avatar csnover commented on September 25, 2024

Thanks for your report! An upstream ticket will be opened to add CONNECT tunnelling through a proxy, but we won’t be changing any dependencies.

from digdug.

lbod avatar lbod commented on September 25, 2024

Hi @csnover, can you let me know if the upstream ticket you mentioned has been added outwith https://bugs.dojotoolkit.org/ticket/18424 ?

I'd like to get some traction on this, whilst the hacking on that ticket worked at home with privoxy, it didn't in my workplace, I'm willing to do more testing/hacking if needed so let me know. I've also pinged @bryanforbes about this

from digdug.

bartoszkaczorek avatar bartoszkaczorek commented on September 25, 2024

Can you explain what's wrong with changing dependencies - why invent a wheel when it's already done?

from digdug.

dylans avatar dylans commented on September 25, 2024

@bartoszkaczorek because we'd rather fix issues with upstream dependencies when possible rather than swapping out an upstream dependency every time there's an issue. There are a number of features in dojo/request that we use for mocking requests, etc., and it wouldn't be very friendly to our users to break those existing patterns. You could argue that anything is a reinvention of something else (e.g. the request library you've linked to isn't the first ever library to solve requests, etc.). :)

from digdug.

csnover avatar csnover commented on September 25, 2024

@bartoszkaczorek In addition to what @dylans said, the request library you’re mentioning introduces other dependencies (= slower install), doesn’t follow our standards and conventions (e.g. using Promises for asynchronous operations), and so would require us to rewrite all the networking code in Dig Dug. It’s not a 1:1 replacement. So there are both philosophical and practical reasons why it’s not possible to simply swap it.

from digdug.

bartoszkaczorek avatar bartoszkaczorek commented on September 25, 2024

For anyone looking for a workaround for this issue: https://www.npmjs.com/package/digdug-null-sauce-labs-tunnel

from digdug.

bryanforbes avatar bryanforbes commented on September 25, 2024

I have started adding more robust proxy configuration to Dojo as part of dojo/core#335.

from digdug.

jason0x43 avatar jason0x43 commented on September 25, 2024

Closing this since Intern and digdug no long use dojo for requests. There is a potentially related issue at theintern/intern#1065 if this still happens with current Intern.

from digdug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.