Comments (7)
Thanks for this lighning fast response! I was able to rebuild the python package :-). It's getting late here, will test this weekend and report back.
from decoder.
Super, will test today. Externally, the TP357 and TP357S look exactly the same, to the point that the TP357S mentions TP357 as product number. So I guess it's just a HW revision. I did my best to try to fix it myself, but it would have taken an extra day or so. I had already discovered the scananddecode
app and concluded that it's just a decoder issue.
from decoder.
I took the quick route and just modified the one file changed. ScanAndDecode results look outstanding:
F9:FA:46:4A:09:15:AdvertisementData(local_name='TP357S (0915)', manufacturer_data={52674: b'\x00>"\x0b\x01'}, rssi=0)
data sent to decoder: {"manufacturerdata": "c2cd003e220b01", "name": "TP357S (0915)", "id": "F9:FA:46:4A:09:15", "rssi": 0}
TheengsDecoder found device: {"manufacturerdata":"c2cd003e220b01","name":"TP357S (0915)","id":"F9:FA:46:4A:09:15","rssi":0,"brand":"ThermoPro","model":"TH Sensor","model_id":"TP35X/393","type":"THB","cidc":false,"acts":true,"tempc":20.5,"tempf":68.9,"hum":62}
{"properties":{"tempc":{"unit":"°C","name":"temperature"},"hum":{"unit":"%","name":"humidity"}}}
brand: ThermoPro , model: TH Sensor
Also in MQTTExplorer the messages are coming through perfectly, with RSSI being non zero most of the time also.
Just need to figure out how to build it for ARM Linux, as I run it normally on a RPI 3 and Orange Pi 5+.
Problem solved in a record time :-)
from decoder.
The Python package can be built by running pip install .
from the repository's python
directory. We would be happy to accept a pull request adding support for the TP357S.
from decoder.
Hi @ewaldc,
Thanks a lot for the update on the ThermoPro TP357S.
Is it just a hardware revision update, or a totally new model? I can't seem to find any info on the TP357S. Do you have any link?
I forked the repo and made the necessary changes to TPTH_json.h (basically just adding the TP357S in the logical OR condition)
The already existing model condition
"name", "index", 0, "TP357", …
should work fine with even the TP357S, as there is only the additional S trailing it, but the manufacturerdata you quoted above is one octet longer, so I changed the AND model condition to
… "&", "manufacturerdata", ">=", 12, "index", 0, "c2"
to also catch the 14 long TP357S manufacturerdata.
You can give this change a test with the branch
https://github.com/DigiH/decoder/tree/TP357S
Leaving the docs unchanged until it is clearer if this is a separate new model or a hardware revsion of the TP357.
Thanks
from decoder.
Thanks for the verification @ewaldc
Merging into the Theengs Decoder development branch …
If any reaming build queries remain please open a discussion for Theengs Decoder or Theengs Gateway.
from decoder.
BTW, if you have some time and feel like taking a picture of your TP357S ("the TP357 and TP357S look exactly the same") on a white background and would allow us to use it in our Decoder compatibility listing, that would be great.
You could just post the image here in the thread and we can include it in the docs.
Thanks
from decoder.
Related Issues (20)
- Add support for INKBIRD IAM-T1 Air Quality Monitor HOT 3
- BM2 fails to decode HOT 29
- more Mopeka Gas Level sensor options, extended range bit HOT 1
- Mi Band 7 ( NO NFC _ NO PRO ) HOT 2
- Incorrect humidity value for Govee H5072/75 when temperature below 0 degree celsius HOT 4
- Include decoding support for SwitchBot Curtain 3 HOT 12
- Add support for PAX Calima HOT 2
- wifi inkbird HOT 1
- Integration of BLE connections to decoder
- add support for e-volve/fitdays smart scale HOT 24
- Switchbot Meter Plus sometimes detected as Tile tracker HOT 7
- SwitchBot Meter models passive broadcast decoding HOT 12
- Add support for WoSensorTHP (passive THX1(W230150X)) HOT 7
- ScanAndDecode.ino connect or not connect ? HOT 1
- Mi band 7 no steps HOT 1
- Is Theengs supported running in Windows? HOT 6
- Decoder for BFOUR Bf-40 / Grill BT5.0 BBQ Thermometer HOT 3
- Add support for Shelly BLU H&T HOT 2
- Add support for stove hood/Safera Sense/RørosHetta HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from decoder.