Extension fails to run if artisan location is in sub directory of the workspace about vscode-laravel-artisan HOT 9 CLOSED

Sorry for the delayed reply, but that looks like it works. Since the file is empty it is starting the extension, but not able to execute commands.

I did find that vscode accepts a glob for the workspaceContains activation event, so replacing with a glob pattern should fix the issue.

Now when the extension launches, it finds all artisan files, and saves them into memory. When you run a command and you have more than one artisan file it will ask which one you want to use. If you only have one artisan file it will use that one.

Because of this change, I will start to phase out the configuration setting artisan.location in favor of a selection box to choose a artisan to use.

Please test this with the updates: laravel-artisan-0.0.21.vsix.zip

Thanks for your help!

from vscode-laravel-artisan.

It looks like that command was using a old way of executing, I updated it to use the new way. Try this one:

laravel-artisan-0.0.21.vsix.zip

from vscode-laravel-artisan.

${workspaceRoot} isn't a valid path. Currently a valid (exact) path is required. I could look into adding ${workspaceRoot} at some point though.

from vscode-laravel-artisan.

@TheColorRed Even with hard path, I still cannot make it work. Sorry, should have mentioned that.

from vscode-laravel-artisan.

Okay, the issue is that the extension isn't starting because the file artisan isn't in the root directory.

For testing purposes, could you create an empty file named artisan in the root then restart vscode and see if that works?

from vscode-laravel-artisan.

I did what you asked: create an artisan empty file in workspace root, then restart vscode.
This time when I run Artisan: List Commands, I get a different error "Could not get the list". Output channel (Laravel Artisan) shows up in console log:

[CMD] php artisan list --format=json
[ERROR] 
[CMD] php artisan route:list
[ERROR] 

from vscode-laravel-artisan.

@TheColorRed Thank you for working on it!

Route list and list artisan commands both work. Most other commands that I tried also work.

There is one thing I am not sure how it works. I try Artisan: Run Command and nothing happens. Is there something else I am supposed to do for that command to work?

Thank you again!

from vscode-laravel-artisan.

I have tried the new install you attached (I notice it's the same version as the one before, so I uninstalled the old one, reload vscode, then install the new vsix). It's still nothing happens when I try Artisan: Run Command.

Update: I deleted the extension folder under .vscode/extensions/ and tried to install it again. This time it works.

Thank you very much for you efforts!

from vscode-laravel-artisan.

Thank you for testing! This has now been published to the marketplace.

from vscode-laravel-artisan.