API Design about marten.fsharp HOT 6 CLOSED

Really nice!
And yes, I also use this library (in my toy project) IDocumentSession as the last parameters.
And this is my function chains as an example.

from marten.fsharp.

Looks great! Though personally, I still don't get when I have to use IQuerySession and IDocumentSession. Perhaps those two can be separated like in Marten's doc.

// query, read, write, etc.
let query<'a> (session : IDocumentSession) =
    session.Query<'a>()
// just query without write.
let query<'a> (session : IQuerySession) =
    session.Query<'a>()

from marten.fsharp.

I've never used IQuerySession before. I guess it's for scenarios which you don't want to accidentally save things. I guess since IDocumentSession
inherits from IQuerySession we can just change the query function to IQuerySession and won't matter if you pass in either.

from marten.fsharp.

Ok I just changed all the read functions like query and load to IQuerySession baa78c4

from marten.fsharp.

Also should I move all the IDocumentSession parameters to be first or last? https://fsharpforfunandprofit.com/posts/partial-application/#designing-functions-for-partial-application

session
|> loadByIntAsync<Person> 42

or

42
|> loadByIntAsync<Person> session

from marten.fsharp.

Ok moved to last param in 50754fc

from marten.fsharp.