Comments (14)
If this is 169 MB file from https://www.markusplassen.no/?p=159 - these windows are now fine. Although there is still a 100+ boolean problems in the file:
edit: I think they are fine because the walls around them are gone 😅
from engine_web-ifc.
Hey @elalish sorry for not letting you know, my bad. We will probably release more bounties to identify these errors, fix the ones related to geometry generation on our side and support your fantastic work (like we did with Garret's three-mesh-bvh), if that's ok with you. 🙂 We'll let you know of any news. In the meantime, of course, feel free to include IFC.js as one of the projects using your library as a dependency, and let us know if you need anything from us.
from engine_web-ifc.
From what I can see this is now rendering correctly. So I will close this
from engine_web-ifc.
Hey @vegarringdal can you confirm that this still happens? Cheers!
from engine_web-ifc.
Nope, but noticed npm version and console is printing out different version...
I just cloned... so I dint not have any old files laying around
from engine_web-ifc.
Hey @vegarringdal yeah that's actually a mistake on our side, you are probably using 35, the log has a typo. If you could provide me the model privately, we'll address this asap. Cheers!
from engine_web-ifc.
I just downloaded a random holter tower IFC file from internet. 😁
Ill see if I have it still when I get home.
from engine_web-ifc.
Hey @makc so still problematic, huh? We'll need to take a deeper look into this when we release more bounties regarding booleans!
from engine_web-ifc.
@agviegas as you see, the most of bugs are meshes where joining the vertices does not make them manifold - those are supposedly easy to figure out. but errors in polygon.cpp are kind of hard to understand, and will probably need to be reported to @elalish with obj files to reproduce.
from engine_web-ifc.
I'd love to know more about what's going on here. Are you referring to merging nearby verts to e.g. make an STL manifold? Like most things, the simple cases are simple, but making it robust can be pretty tricky. Certainly pass any Manifold
errors back to our library. In fact, I have some flags for verbosity that help with spitting out polygon error cases (which is how I've created a lot of my tests).
Speaking of, I had no idea you took me on as a dependency; that's exciting! Ideally I'd like to keep a list somehow of what projects are using the library, though it seems easier said than done. Anyway, thanks for mentioning me.
from engine_web-ifc.
@elalish I could log input mesh if you are willing to take a look at that in the context of polygon.cpp error;
Are you referring to merging nearby verts to e.g. make an STL manifold
currently ifc input data is just a triangle soup - so I have attempted to merge the vertices back before passing to manifold lib and when we have a simple enough mesh it works. but I guess there are cases where too many vertices touch and then merging them is doing nothing but harm.
from engine_web-ifc.
Yeah, this is why triangle soup like STL is such a problem - it's basically impossible to reliably retain manifoldness in general cases. This is why I helped develop the 3MF format, which is focused on defining and retaining manifoldness.
Yes, please log the input meshes you're having trouble with. If you can manage to write a PR with a TEST
case that reproduces it, that would be the best, but an issue with some repro steps would also be helpful.
from engine_web-ifc.
@agviegas here is an example of non-manifold hole that breaks this tower file:
again, 2 boxes together in one hole, just like in #126 - so I guess the same issue.
from engine_web-ifc.
Fantastic, keep those bug reports coming! And certainly let me know if have any comments on the API.
from engine_web-ifc.
Related Issues (20)
- [Bug]: 404 at ifcjs.github.io/web-ifc/demo/ HOT 4
- [Bug]: IfcBoolean value is written as '.true.' instead of '.T.' HOT 3
- [Bug]: Something still went wrong geometry with version @0.0.51 , HOT 2
- [Bug]: It does not load IFCMEMBERS from an IFCCURTAINWALL HOT 5
- [Bug]: Incorrect clipping of thin solids HOT 1
- [Bug]: Some geometry went wrong with versions @0.0.51, @0.0.52 and @0.0.53 with older versions is fine HOT 3
- [Bug]: 2 Closed Issues are still present in web-ifc 0.0.53 (as far as i know it is not a regression, because it never worked to begin with) HOT 1
- Version 1.4.21 has a bug regarding the position of some objects, namely IFCREINFORCINGBAR HOT 5
- [Bug]: Profile error
- [Bug]: Missing geometries in big ship model
- [Bug]: Error loading spatial structure on model with IfcAlignment
- With @web-ifc we can split the Uint8Array into chunks to read? HOT 5
- [Bug]: Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './web-ifc-api' is not defined by "exports" in D:\App\Backend\node_modules\web-ifc\package.json HOT 5
- [Bug]: Some objects are not displayed in web-ifc based viewer.
- [Bug]: Error with geometry and miss some of them HOT 1
- Add new IFC element at specific co-ordinate in the loaded 3D view HOT 1
- [Bug]: Vite/vue3 wasm issue HOT 1
- [Bug]: error with geometry of basic model HOT 1
- [Bug]: IFC Model Alignment Issue
- [Bug]: Model processing results in Aborted()
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from engine_web-ifc.