More coherent slot support about crypto11 HOT 3 CLOSED

I'm down with exposing a key id. In general I wonder whether we need more of an interface around keys if we want to set labels as they're mutable. In addition I wonder if we should have a "factory" interface around tokens for generating, deleting and listing keys and managing said token.

from crypto11.

The scope of this library should remain small. Do one thing and do it well.

The goal was to provide PKCS#11 implementations for Go crypto interfaces. This would allow HSMs to be used in the "pluggable" parts of the Go crypto ecosystem (e.g. crypto.Signer).

The Go crypto packages provide no interfaces key generators and thus no way to approach this in a pluggable fashion. I see no benefit in providing a partial solution for key generation, when miekg/pkcs11 offers full access to the HSM.

The potential exception to this is session keys, which cannot currently be generated in separate calls to miekg/pkcs11 and used with our library. However, if people bump into that requirement, we should analyse it separately and consider all possible solutions.

IMO, key generation was scope creep and we will probably remove it in the future (with a suitable deprecation period). Consequently, I don't see a benefit in enhancing the existing support.

from crypto11.

I'm closing this. Comments on the new design are welcome at #36.

from crypto11.