Fix e2e testing about app HOT 5 CLOSED

@layik Looks like the e2e tests go wrong only on release, i.e. when the Upgrade tgve.js job (which looks a bit weird) runs. I'll have a look at this in more detail tomorrow.

from app.

It [e2e] works only by splitting it, should work in one file too!
3f8b731

from app.

Hi @rolyp, just noticed that above commit passed in what is e2e.yml in branch issue55 but this one fails
7d0771e

I doubt it is anything to do with macOS? I will ask for your review of the PR.

from app.

Some notes:

1. It’s important to run with dumpio enabled in puppeteer.launch. Timeouts because no element matches a selector are often masked by generic ProtocolError: Protocol error (Runtime.callFunctionOn): Target closed. By default Puppeteer absorbs any console output from the web app.

2. Testing against the file protocol and build directory seemed to cause React error 321 (duplicate copy of React) error to resurface, even with the script to purge React from the copy of tgvejs in app. This was resolved by switching back to a webserver and regular URLs.

3. The “Upgrade tgve.js” step was also causing problems, and anyway seemed hard to justify. The decision to upgrade tgve.js should be taken by the user, not automatically by a build script, and such a change shouldn’t be commited before tests have been run. Removed this step.

4. Removed the “Set homepage” step and instead do this in the Build [release] step via PUBLIC_URL.

5. Fixed the problem where the tests were running against the node-installed version of tgvejs, rather than the version checked out in GitHub Actions. The app tests now run against the develop branch of tgvejs. In other words, pushing to tgvejs may invalidate the tests on app, although that won’t become apparent until the next build of app.

6. Existing App.js.test script wasn’t contributing much. Deleted.

7. Ensuring the e2e tests start up properly (without the webserver startup causing the first test to time out) and shutdown properly is done using concurrently and wait-on (see the yarn test script for more information).

from app.

All noted. I think as said on Slack, the e2e needs to move under tgvejs.

from app.