Exception thrown with duplicate strings about xlnt HOT 7 CLOSED

Nice debugging work. I've added a fix to the shared strings serialization code that should take care of this for you. I'm currently refactoring much of the serialization so I don't want to spend too much time on making this more performant (specifically removing duplicates after loading the workbook).

from xlnt.

Perfect, many thanks! Performance isn't a problem for me at the moment so no complaints there.

from xlnt.

From the ISO/IEC 29500 18.4.9 sst(Shared String Table)
"A string is unique even if it is a copy of another string, but has different formatting applied at the character level."

Character level formatting will break the string into multiple text runs (multiple "t" child). The current code only picks up the first text run. More over, since it ignores all the character level formatting, unique "si" may still end up the same string value.

from xlnt.

Thanks Wei. I should have checked the standard. I'll be pushing some big updates in the next week so I'll try to implement this more correctly in that release.

from xlnt.

Thanks! Great work!

from xlnt.

FYI, unrelated to @wei-sketchup's issue, I have worked out the cause of the duplicate shared strings in the #42 test case. It turns out that Excel only does string deduplication when you enter them by hand. When you copy and paste a large block of data (e.g. from a .csv file) then Excel does not perform deduplication, I guess for performance reasons. This is why you end up with duplicate shared strings in that case where you really shouldn't as they are truly identical.

from xlnt.

I appreciate the follow-up Adam. I was debating asking you how I could reproduce this issue. I have a lot to go on now!

from xlnt.