Comments (8)
I'm not sure the deadlock detection is hiding an error. Without the timeout, it would have frozen.
If a broken compose prevents a mount or prune, we might have to handle that case explicitly.
from textual.
It was definitely hiding an error (to be clear, I mean an error in my app, not Textual, inside a widget's compose
method. By "hiding", I mean there was no stack trace printed by Textual anywhere indicating why my app crashed, just the TimeoutError) - I wrapped the code that contained an exception in a try/except and printed out the exception.
When I didn't catch the error myself, it bubbled up to Textual and the app crashed with the deadlock issue after 5 seconds, and there was no sign of the original error.
from textual.
I will try to MRE this tomorrow.
from textual.
Have spent some time trying and failing to MRE this, but I'm pretty certain there's an issue.
My app had a logic bug which caused a plain old exception to be raised, but Textual never presented that exception to the user. The user was only presented with "possible deadlock" when the app crashed.
from textual.
I just hit this issue again - receiving a "possible deadlock" which is hiding another exception in my app, making debugging difficult.
I think it's unrelated to screens and is a more general issue - trying another MRE now.
from textual.
Override _handle_exception
in the App
:
E.g.:
def _handle_exception(self, error: Exception) -> None:
global exc
exc = error
super()._handle_exception(error)
It'll allow you to see the errors
from textual.
I've also noticed that I get this warning in the devtools each time I see the deadlock issue:
[14:45:01] WARNING _callback.py:73
Callback functools.partial(<function
Footer.on_mount.<locals>.bindings_changed at 0x1047f87c0>, MainScreen()) is
still pending after 3 seconds
from textual.
Seems to not be restricted to 0.71.0.
@arcivanov The issue here is exceptions are not making it into Textual's usual error handling flow, so this doesn't do anything in this case.
from textual.
Related Issues (20)
- v0.68.0 test_deadlock is failing HOT 12
- Some minor documentation additions HOT 3
- Add Image support using imgcat HOT 6
- Callback is not called when Screen is dismissed HOT 13
- `Tree.select_node` doesn't select the node, it highlights it HOT 2
- Using standard python logger HOT 3
- Documentation is not up-to-date HOT 3
- Travel back in time to 1900 HOT 2
- Crash opening and closing dialog really fast HOT 25
- On exit Texual always prints a lonely "<" to console HOT 3
- Workers report RUNNING state twice HOT 4
- Allow mouse-resizable Grid/Vertical/Horizontal with click-hold-drag-release type of resizing HOT 1
- Deadlock when closing app, associated with Footer.recompose and focus events HOT 5
- Right and bottom gets cut from keyline when using auto for width and height HOT 3
- MD links inside a MD table in Markdown Widget do not generate Markdown.LinkClicked when clicked HOT 2
- Update documentation HOT 2
- "Can't mount widget(s) before Vertical() is mounted" when reactive recompose HOT 1
- Pasting "〽️" in TextArea Moves Cursor Too Far HOT 11
- Textual 0.71 introduces another deadlock in Memray's test suite
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from textual.