Giter Club home page Giter Club logo

Comments (5)

TomJGooding avatar TomJGooding commented on May 25, 2024 1

For example, if you click in the middle of a TextArea which does not have focus, then the cursor is briefly drawn at the end of the text before appearing where you clicked.

I can't seem to reproduce this issue, could you possibly share a screen recording of what you are seeing?

text-area-click-focus.mp4
from textual.app import App, ComposeResult
from textual.widgets import Button, TextArea

TEXT = """I must not fear.
Fear is the mind-killer.
Fear is the little-death that brings total obliteration.
I will face my fear.
I will permit it to pass over me and through me.
And when it has gone past, I will turn the inner eye to see its path.
Where the fear has gone there will be nothing. Only I will remain."""


class ClickFocusApp(App):
    def compose(self) -> ComposeResult:
        yield Button()
        yield TextArea(TEXT)


if __name__ == "__main__":
    app = ClickFocusApp()
    app.run()

from textual.

davep avatar davep commented on May 25, 2024

This doesn't seem to work for me with the current Textual, but that's a separate issue.

This would suggest you've not installed devtools.

from textual.

TomJGooding avatar TomJGooding commented on May 25, 2024

Another example is ListView, where if you have a list view without focus where the action is to close the screen, then clicking on an item (other than the first) in the ListView will never show it as highlighted before it is destroyed.

Wouldn't you need a short delay before closing the screen to give the user chance to observe the selection? Something like this:

from textual import on
from textual.app import App, ComposeResult
from textual.screen import Screen
from textual.widgets import Button, Label, ListItem, ListView


class ExampleScreen(Screen):
    def compose(self) -> ComposeResult:
        yield Button()
        yield ListView(
            ListItem(Label("One")),
            ListItem(Label("Two")),
            ListItem(Label("Close this screen"), id="close-screen"),
        )

    @on(ListView.Selected)
    def on_list_view_selected(self, event: ListView.Selected) -> None:
        if event.item.id == "close-screen":
            self.set_timer(0.2, self.dismiss)


class ClickFocusApp(App):
    def on_mount(self) -> None:
        self.push_screen(ExampleScreen())


if __name__ == "__main__":
    app = ClickFocusApp()
    app.run()

from textual.

davep avatar davep commented on May 25, 2024

Another example is ListView, where if you have a list view without focus where the action is to close the screen, then clicking on an item (other than the first) in the ListView will never show it as highlighted before it is destroyed.

I suspect this is one of those places where you'd use call_after_refresh. For example, see how this looks:

from textual import on
from textual.app import App, ComposeResult
from textual.widgets import ListView, ListItem, Label

class ListViewMenuApp(App[None]):

    def compose(self) -> ComposeResult:
        yield ListView(
            ListItem(Label("Beep"), id="beep"),
            ListItem(Label("Close"), id="close")
        )

    @on(ListView.Selected, item="#beep")
    def do_beep(self) -> None:
        self.bell()

    @on(ListView.Selected, item="#close")
    def do_close(self) -> None:
        self.exit()

if __name__ == "__main__":
    ListViewMenuApp().run()

vs this:

from textual import on
from textual.app import App, ComposeResult
from textual.widgets import ListView, ListItem, Label

class ListViewMenuApp(App[None]):

    def compose(self) -> ComposeResult:
        yield ListView(
            ListItem(Label("Beep"), id="beep"),
            ListItem(Label("Close"), id="close")
        )

    @on(ListView.Selected, item="#beep")
    def do_beep(self) -> None:
        self.bell()

    @on(ListView.Selected, item="#close")
    def do_close(self) -> None:
        self.call_after_refresh(self.exit)

if __name__ == "__main__":
    ListViewMenuApp().run()

from textual.

ZandevOxford avatar ZandevOxford commented on May 25, 2024

Hmm. I concur that that simple example doesn't show the visual problem.

I suspect the issues I'm seeing are due to the focus causing a redraw in my app, then processing the mouse afterwards. I'll have to see if I can come up with a sensible reproduction case.

from textual.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.