`TextArea` still has a cursor, until it's had focus and then lost it about textual HOT 8 CLOSED

Cheers - I reckon this will be changing a True to a False somewhere 😄

from textual.

I had a quick look at this and found that if you set cursor_blink = False (needed for snapshot testing), the TextArea still has a cursor even after focussing then blurring:

from textual.app import App, ComposeResult
from textual.widgets import Input, TextArea


class TextAreaCursorApp(App[None]):
    def compose(self) -> ComposeResult:
        input = Input()
        text_area = TextArea()
        input.cursor_blink = False
        text_area.cursor_blink = False
        yield input
        yield text_area


if __name__ == "__main__":
    TextAreaCursorApp().run()

Then I spotted that the _on_blur method actually also seems to set the cursor to be visible which is confusing? Changing this to False has no effect, which suggests the cursor visibility must actually be updated elsewhere...?

EDIT: Ah-ha, I missed that it also has this watch method!

from textual.

Oh yeah, the _on_blur can probably be removed. It was intended to ensure that the cursor remains visible when it's blurred for consistency. Otherwise the visibility of the cursor depended on when you blurred the widget.

I was thinking initialising self._cursor_visible to False in the constructor might be enough.

from textual.

Just to note for whoever picks this up (maybe me!), potentially any fix should also account for this issue:

• #3405

from textual.

Oh yeah, the _on_blur can probably be removed. It was intended to ensure that the cursor remains visible when it's blurred for consistency. Otherwise the visibility of the cursor depended on when you blurred the widget.

Sorry I'm not sure I fully understand this - is that just the old implementation, or related to #2476?

from textual.

Sorry, I meant the _on_blur could be removed because we could handle the logic of pausing the blink insidewatch_has_focus instead, rather than doing blur-related stuff in 2 places. We'll probably need to pause blink in watch_has_focus with visible=False.

from textual.

I'm going to pick this up now.

from textual.

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

from textual.