Giter Club home page Giter Club logo

Comments (4)

davep avatar davep commented on June 16, 2024

Diving into the innards with this:

from textual import on
from textual.app import App, ComposeResult
from textual.containers import Horizontal
from textual.reactive import var
from textual.widgets import Button, OptionList, Pretty
from textual.widgets.option_list import Option

class OptionListReAdd(App[None]):

    CSS = """
    OptionList {
        height: 1fr;
    }

    Horizontal {
        height: 2fr;
        Pretty {
            width: 1fr;
        }
    }
    """

    count: var[int] = var(0)

    def compose(self) -> ComposeResult:
        yield Button("Add again")
        yield OptionList()
        with Horizontal():
            yield Pretty([], id="options")
            yield Pretty([], id="ids")

    @on(Button.Pressed)
    def readd(self) -> None:
        self.count += 1
        self.query_one(OptionList).add_option(
            Option(f"Option {self.count}", id=str(self.count))
        )
        self.query_one("#options", Pretty).update(
            self.query_one(OptionList)._options
        )
        self.query_one("#ids", Pretty).update(
            self.query_one(OptionList)._option_ids
        )

if __name__ == "__main__":
    OptionListReAdd().run()

I see this:

Screenshot 2024-02-01 at 21 12 09

it looks like the changes made have introduced some sort of off-by-one error on the index mapping for each ID.

from textual.

davep avatar davep commented on June 16, 2024

It's a bit late in the evening for me to do a PR with confidence, but it looks like the issue is fixed with something like this:

diff --git a/src/textual/widgets/_option_list.py b/src/textual/widgets/_option_list.py
index 59e2adf9..9366f071 100644
--- a/src/textual/widgets/_option_list.py
+++ b/src/textual/widgets/_option_list.py
@@ -596,13 +596,14 @@ class OptionList(ScrollView, can_focus=True):
             # Turn any incoming values into valid content for the list.
             content = [self._make_content(item) for item in items]
             self._duplicate_id_check(content)
+            start = len(self._options)
             self._contents.extend(content)
             # Pull out the content that is genuine options. Add them to the
             # list of options and map option IDs to their new indices.
             new_options = [item for item in content if isinstance(item, Option)]
             self._options.extend(new_options)
             for new_option_index, new_option in enumerate(
-                new_options, start=len(self._options)
+                new_options, start=start
             ):
                 if new_option.id:
                     self._option_ids[new_option.id] = new_option_index

The calculation of the new index values for the mapping is currently starting after the new options have been added, when it should go from the last position before they're added (is how it looks to me).

Pinging @rodrigogiraoserrao for a double-check as this does seem to be from b1aaea7

from textual.

davep avatar davep commented on June 16, 2024

A test like this illustrates the issue:

from textual.app import App, ComposeResult
from textual.widgets import OptionList
from textual.widgets.option_list import Option

class OptionListApp(App[None]):
    """Test option list application."""

    def compose(self) -> ComposeResult:
        yield OptionList()

async def test_get_after_add() -> None:
    """It should be possible to get an option by ID after adding."""
    async with OptionListApp().run_test() as pilot:
        option_list = pilot.app.query_one(OptionList)
        option_list.add_option(Option("0", id="0"))
        assert option_list.get_option("0").id == "0"

This will fail.

from textual.

github-actions avatar github-actions commented on June 16, 2024

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

from textual.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.