Editing CSS with e.g. vim can crash an app about textual HOT 8 CLOSED

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

from textual.

I always forget the live editing feature so don't use it as often as I should, but I can't seem to reproduce this with a quick few tests.

Out of interest, do you have backups in vim off or on?

:set backup?

It might be useful to know what versions of textual and textual-dev you're working with too?

from textual.

I always forget the live editing feature so don't use it as often as I should, but I can't seem to reproduce this with a quick few tests.

I should have mentioned (or though of, rather) that when I hit this, I was working on a textual project that's stored on a NFS share. I tried reproducing it with a local copy, and I can't (did a quick couple of tests). It anyway seems to be a bug to not handle the potential exception from os.stat in the code I referred to above though?

Out of interest, do you have backups in vim off or on?

:set backup?
nobackup

It might be useful to know what versions of textual and textual-dev you're working with too?

The latest via pip in a custom venv:

Using cached textual-0.47.1-py3-none-any.whl
Using cached textual_dev-1.4.0-py3-none-any.whl (26 kB)

from textual.

It anyway seems to be a bug to not handle the potential exception from os.stat in the code I referred to above though?

I'd second this; there's enough editor backup approaches that do a move then write approach to make this a sensible approach.

from textual.

...I can't seem to reproduce this with a quick few tests.

@TomJGooding another (contrived) way to reproduce it is to start a Textual app and then rename the CSS file...that'll also cause a crash...

from textual.

Catching that exception seems reasonable, even if we can't reproduce the issue.

from textual.

Although I didn't try to replicate the issue using vim, I could write a unit test to simulate this scenario. It should hopefully be resolved by #4079 - the FileMonitor should now be able to handle files becoming unavailable temporarily.

from textual.

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

from textual.