Comments (16)
Thank you, I will reach out to you as I progress.
from textual.
Hello @rodrigogiraoserrao
Please do check out the changes I made, thank you for your patience, I do appreciate and I don't take it for granted because I don't think I would be able to navigate my way through without your guidance.
from textual.
Checked; panel
is the only type missing. Also needs to be added to the TCSS grammar.
from textual.
Hi @rodrigogiraoserrao I would love to help with resolving the issue.
from textual.
Hi I would like to contribute and help resolving the issue.
from textual.
Feel free to have a go at this.
Disclaimer: in a week or two if there hasn't been any progress I'll do this myself :)
from textual.
Also needs to be added to the TCSS grammar.
The grammar and the VS Code extension have been updated. ✅
from textual.
Hi @rodrigogiraoserrao, you were really fast with it and this swept me off my feet.
I am in a straight now, how do I go about this?
from textual.
@AkintolaRichard do you have any experience with Textual? (E.g., have you gone over the tutorial in the docs?)
Going over the CONTRIBUTING.md file is also a good idea.
Essentially, you'll need to tweak two documentation pages so that the border type panel
is documented in:
- the table in https://textual.textualize.io/css_types/border/
- the “border_all” example app in https://textual.textualize.io/styles/border/#all-border-types
from textual.
@rodrigogiraoserrao I am still going through the documentation and I found out that the concerned files are located in the border.md file in the css_types directory and the border.md file in the styles directory.
from textual.
Yeah. The file in the css_types
directory contains the table inside and it can be modified directly.
The file border.md
in the styles
directory will have some funny syntax with
```textual ...
```
That's used to run a Textual app in the file path specified.
One of those should be a border_all.py
app that tries to show all border types.
For that one, you need to modify the Textual app and make sure it runs well and that it includes the panel
border type.
from textual.
Hello @rodrigogiraoserrao
I am sorry for keeping you waiting, having gone through the tutorial in the doc, I am in a straight on putting the description for the panel border.
from textual.
I don't understand what your difficulty is.
What question(s) do you have?
from textual.
Okay, I noticed that there is a short description for each border type, so I want to ask if there is a formal description or I should create the description myself.
I am really sorry for stressing you, this is my first open source contribution experience.
from textual.
I understand what you are asking now.
You should create the description yourself: a short sentence that describes decently the way the border type looks.
from textual.
Don't forget to star the repository!
Follow @textualizeio for Textual updates.
from textual.
Related Issues (20)
- Add `remove` attribute to `mount` and `mount_all` HOT 7
- Add a `lock` to every widget. HOT 3
- Clarify `Input` docs about removing spacing HOT 2
- Input widgets error when I configure type arguments
- A Widget with {margin: 1} style in a ScrollableContainer causes infinite resizes and scrollbars flicker HOT 7
- Pilot cannot click switch with horizontally aligned, long text HOT 5
- Clarify `is_end_of_document_line` in docs HOT 6
- Omitting TextArea theme doesn't highlight
- TabbedContent active attribute doesn't post message TabActivated + doesn't arrange tabs HOT 5
- TextArea crashes Python on html language HOT 5
- Blank display on AIX HOT 10
- check error in the "textual colors" app HOT 7
- Search Functionality for the Select Widget HOT 5
- No display on non-UTF8 locale HOT 3
- Tab scrolling not working HOT 5
- No Tcss file included in documentation for On_decorator example HOT 3
- Stop `TextArea` cursor moving beyond end of line in `read_only` mode? HOT 1
- Event documentation doubles up the bubble and verbose checkboxes HOT 3
- `grid-rows: auto` seems to be broken when `column-span`/`Pretty` is used HOT 5
- Dynamic bindings update HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from textual.