Giter Club home page Giter Club logo

Comments (16)

AkintolaRichard avatar AkintolaRichard commented on September 24, 2024 1

Thank you, I will reach out to you as I progress.

from textual.

AkintolaRichard avatar AkintolaRichard commented on September 24, 2024 1

Hello @rodrigogiraoserrao
Please do check out the changes I made, thank you for your patience, I do appreciate and I don't take it for granted because I don't think I would be able to navigate my way through without your guidance.

from textual.

rodrigogiraoserrao avatar rodrigogiraoserrao commented on September 24, 2024

Checked; panel is the only type missing. Also needs to be added to the TCSS grammar.

from textual.

AkintolaRichard avatar AkintolaRichard commented on September 24, 2024

Hi @rodrigogiraoserrao I would love to help with resolving the issue.

from textual.

Kyl67899 avatar Kyl67899 commented on September 24, 2024

Hi I would like to contribute and help resolving the issue.

from textual.

rodrigogiraoserrao avatar rodrigogiraoserrao commented on September 24, 2024

Feel free to have a go at this.

Disclaimer: in a week or two if there hasn't been any progress I'll do this myself :)

from textual.

rodrigogiraoserrao avatar rodrigogiraoserrao commented on September 24, 2024

Also needs to be added to the TCSS grammar.

The grammar and the VS Code extension have been updated. ✅

from textual.

AkintolaRichard avatar AkintolaRichard commented on September 24, 2024

Hi @rodrigogiraoserrao, you were really fast with it and this swept me off my feet.
I am in a straight now, how do I go about this?

from textual.

rodrigogiraoserrao avatar rodrigogiraoserrao commented on September 24, 2024

@AkintolaRichard do you have any experience with Textual? (E.g., have you gone over the tutorial in the docs?)
Going over the CONTRIBUTING.md file is also a good idea.
Essentially, you'll need to tweak two documentation pages so that the border type panel is documented in:

from textual.

AkintolaRichard avatar AkintolaRichard commented on September 24, 2024

@rodrigogiraoserrao I am still going through the documentation and I found out that the concerned files are located in the border.md file in the css_types directory and the border.md file in the styles directory.

from textual.

rodrigogiraoserrao avatar rodrigogiraoserrao commented on September 24, 2024

Yeah. The file in the css_types directory contains the table inside and it can be modified directly.
The file border.md in the styles directory will have some funny syntax with

```textual ...
```

That's used to run a Textual app in the file path specified.
One of those should be a border_all.py app that tries to show all border types.
For that one, you need to modify the Textual app and make sure it runs well and that it includes the panel border type.

from textual.

AkintolaRichard avatar AkintolaRichard commented on September 24, 2024

Hello @rodrigogiraoserrao
I am sorry for keeping you waiting, having gone through the tutorial in the doc, I am in a straight on putting the description for the panel border.

from textual.

rodrigogiraoserrao avatar rodrigogiraoserrao commented on September 24, 2024

I don't understand what your difficulty is.
What question(s) do you have?

from textual.

AkintolaRichard avatar AkintolaRichard commented on September 24, 2024

Okay, I noticed that there is a short description for each border type, so I want to ask if there is a formal description or I should create the description myself.
I am really sorry for stressing you, this is my first open source contribution experience.

from textual.

rodrigogiraoserrao avatar rodrigogiraoserrao commented on September 24, 2024

I understand what you are asking now.
You should create the description yourself: a short sentence that describes decently the way the border type looks.

from textual.

github-actions avatar github-actions commented on September 24, 2024

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

from textual.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.