testcafe-testing-library's custom Selector didn't work in testcafe page model about testcafe-testing-library HOT 5 CLOSED

On Wed, May 22, 2019 at 10:05 AM Artikodin ***@***.***> wrote: Hi, when I use custom Selector (getBy, getByAll ...) provided by testcafe-testing-library in testcafe's page model <https://devexpress.github.io/testcafe/documentation/recipes/use-page-model.html> that throw me an error. So I'm obliged to use the legacy Selector in that case. [image: Screen Shot 2019-05-22 at 18 34 54] <https://user-images.githubusercontent.com/16764987/58192964-3a973b00-7cc2-11e9-8a43-6d15b3064de6.png> Here is a sample of my test : // Error test('should correctly handle error when a wrong password is typed', async t => { await loginPage.login(login, 'WRONG PASSWORD'); await t.expect(loginPage.errorWrongPassword).ok(); }); // Correct test('should correctly handle error when a wrong password is typed ', async t => { await loginPage.login(login, 'WRONG PASSWORD'); await t.expect(loginPage.errorWrongPassword2).ok(); }); Here is a sample of my page model : import { getByTestId, getByPlaceholderText } from 'testcafe-testing-library'; import { t, Selector } from 'testcafe'; export default class LoginPage { constructor() { this.usernameInput = getByPlaceholderText(/username/i); this.passwordInput = getByPlaceholderText(/password/i); this.submitButton = getByTestId('submit'); this.errorIsEmpty = Selector('[data-testid="error-isEmpty"]'); // Error this.errorWrongPassword = getByTestId('wrong-credentials'); // Correct this.errorWrongPassword2 = Selector('[data-testid="wrong-credentials"]'); } async login(username, password) { await t .typeText(this.usernameInput, username) .typeText(this.passwordInput, password) .click(this.submitButton); } } Thank you for taking a look on that issue guys. 👍 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#18?email_source=notifications&email_token=AADBPBEOM6UE5TY4OBGJ5X3PWV4NNA5CNFSM4HOWIOW2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GVIOHBA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADBPBDABGJKLGCSKGOBHXTPWV4NNANCNFSM4HOWIOWQ> .

On Fri, May 24, 2019 at 3:29 AM Artikodin ***@***.***> wrote: Hey @benmonro <https://github.com/benmonro> thanks for your answer. But I've already include the addTestcafeTestingLibrary call in my test I just didn't notified it in my sample 😬. // [...] import { addTestcafeTestingLibrary } from 'testcafe-testing-library'; import LoginPage from './model'; fixture`The login page`.beforeEach(addTestcafeTestingLibrary).page`http://localhost:3000`; // [...] // Error test('should correctly handle error when a wrong password is typed', async t => { await loginPage.login(login, 'WRONG PASSWORD'); await t.expect(loginPage.errorWrongPassword).ok(); }); // Correct test('should correctly handle error when a wrong password is typed ', async t => { await loginPage.login(login, 'WRONG PASSWORD'); await t.expect(loginPage.errorWrongPassword2).ok(); }); But maybe I should include it in my model. If you have an idea how to do that cause I've tried without success 😅. import { getByTestId, getByPlaceholderText, addTestcafeTestingLibrary } from 'testcafe-testing-library'; import { t, Selector } from 'testcafe'; // I've tried here // addTestcafeTestingLibrary() export default class LoginPage { constructor() { // ... here // addTestcafeTestingLibrary() this.usernameInput = getByPlaceholderText(/username/i); this.passwordInput = getByPlaceholderText(/password/i); this.submitButton = getByTestId('submit'); this.errorIsEmpty = Selector('[data-testid="error-isEmpty"]'); // Error this.errorWrongPassword = getByTestId('wrong-credentials'); // Correct this.errorWrongPassword2 = Selector('[data-testid="wrong-credentials"]'); } async login(username, password) { // ... and here // addTestcafeTestingLibrary() await t .typeText(this.usernameInput, username) .typeText(this.passwordInput, password) .click(this.submitButton); } } Thanks 👍 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18?email_source=notifications&email_token=AADBPBA5HRMTCOHRMPSMNMTPW67PRA5CNFSM4HOWIOW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWE3JNY#issuecomment-495563959>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADBPBFIKG2VROHWKLQBWH3PW67PRANCNFSM4HOWIOWQ> .