All(?) timeouts report as "cy.then() timed out after waiting '4000ms'" rather than printing actual expectation failure about cypress-testing-library HOT 5 CLOSED

Interestingly, all the failures also report that they timed out after waiting only 4000ms despite my tests specifying custom timeouts for them all.

Each one of those failed with a CypressError: cy.then() timed out after waiting '4000ms'. message.

from cypress-testing-library.

After a bit of digging, it looks like maybe ab5263d introduced a bug.

Previously there was this code:

.window({log: false})
.then({timeout: waitOptions.timeout + 100}, thenHandler)

but the then has been replaced and doesn't retain the timeout option.

Tentative testing with the timeout re-added seems to have fixed the issue of timeouts not being respected (see: jagregory@d7fe43e). I'm unsure whether this also fixes the incorrect failure messages (I assume that's what the + 100 is for)

from cypress-testing-library.

I can confirm that with the above mentioned change, if a legitimate timeout occurs I now get the expected message. For example: CypressError: Timed out retrying: Expected to find element: '#option-1', but never found it.

from cypress-testing-library.

🎉 This issue has been resolved in version 5.0.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from cypress-testing-library.

We did have tests to check the timeouts were adhered to, I imagine a scenario was being missed.

@jagregory would you be able to add a test which shows the initial failure? It would be good to have a test in the suite to confirm this doesn't get broken again.

from cypress-testing-library.