url.parse not consistent with node.js url.parse about t1-runtime HOT 8 OPEN

This might be a good opportunity to just lift the url.js implementation from Node.

https://github.com/joyent/node/blob/master/lib/url.js

It's 700 lines of code, but it's fairly independent. If the runtime punycode implementation is fully Node-compatible, it should be straightforward.

from t1-runtime.

When pulling Node.js version of url it worked great. No issues when running it with colony.

Pushed those changes to my fork if you want to give it a try. AdamMagaluk@78e3d06

from t1-runtime.

Spoke too soon, seems to be breaking on test/net/http-get-query.js after running make colony

from t1-runtime.

@AdamMagaluk @tcr @johnnyman727

This looks like a RegExp bug (reference: #107). The problem line is here: https://github.com/joyent/node/blob/master/lib/url.js#L216

It should split the hostname into an array, ['api', 'openweathermap', 'org'], but it looks like String.prototype.split isn't running with 'g' flag logic. The resulting array from the runtime is ['api', 'openweathermap.org']. The .org part gets stripped out as invalid later on in the function.

from t1-runtime.

@AdamMagaluk

Confirmed that all tests pass when using Node's url.js and including the fix in PR #110.

from t1-runtime.

Fixed with #111

from t1-runtime.

Reopening this. Added more tests for url.parse that parse local paths like /one/two/three. I also added tests for url.format and url.resolve.

My guess is it's related to some of the regex replacing and matching based on some of the other issues.

Tests here: AdamMagaluk@a7c0235

from t1-runtime.

Also, not all of your tests are running due to #126.

from t1-runtime.