Giter Club home page Giter Club logo

Comments (9)

terrymun avatar terrymun commented on June 15, 2024

I can't seem to reproduce your issue. Tested on Chrome 53.0.2785.116 (64-bit) and Chrome Canary 55.0.2865.0 (64-bit), both are working without a hitch.

What do you mean by "not working"?

from paver.

pembo13 avatar pembo13 commented on June 15, 2024

I see what you're seeing on one computer, but on the one I happened to be on at the time I'm still seeing it not working. And by that, I mean I'm getting class="paver--fallback" and not of the panning functionality.

from paver.

terrymun avatar terrymun commented on June 15, 2024

I'm sorry, but without any further information it is next to impossible to debug. How does the markup in the non-functional version look like? Is the markup being replaced, or is it not?

from paver.

pembo13 avatar pembo13 commented on June 15, 2024

The markup is being replaced, and is in the fallback state. I'll reinstall this Google Chrome, and try on other machine to attempt to replicate the failure. If I can, I'll refile the bug.

from paver.

pembo13 avatar pembo13 commented on June 15, 2024

Dell Inspiron 5558 (notebook, touch support with 10 touch points)
Windows 10 Home 64-bit
Google Chrome 53.0.2785.116 m
Mozilla Firefox 48.0.2

On this machine Firefox functions fully with Paver. On Google Chrome however, it enters fallback mode.

With setup and Google Chrome, document.createEvent('TouchEvent') executes successfully. So global.features.isTouch = true while global.features.hasGyroscope == false. Resulting in a call to this.fallback().

Just to test out, forcing global.features.isTouch = false seems to let things work as expected in Google Chrome, though that's obviously not a fix.

from paver.

terrymun avatar terrymun commented on June 15, 2024

That is quite peculiar. I am unable to reproduce your issue on Chrome, but that's on OS X. I'll see if I can grab a Windows machine to try it on.

from paver.

pembo13 avatar pembo13 commented on June 15, 2024

I'd like to highlight, just in case, that my particular machine is touchscreen laptop.

from paver.

terrymun avatar terrymun commented on June 15, 2024

If that's the case, sounds like something is off with the determination of the device supports touch events. I'll try to see if that's something that I can debug and fix. The code for determining if the device is "touch" or not is rather a misnomer itself, as it does the following:

  1. Checks if the device supplies gyroscopic data and,
  2. Checks if tilting is enabled in the initialisation settings

So it seems like the touchscreen laptop is satisfying both conditions, but for some reason does not supply the correct gyroscopic data. That should've been caught by a fail-safe check performed for point no. 1, but it seems to be failing in your case.

For now try manually forcing isTouch, but I do acknowledge it's only a workaround and not a true fix.

from paver.

pembo13 avatar pembo13 commented on June 15, 2024

Let me know anything I can do to assist.

from paver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.