Incompatibility with Throughout the Ages (crashes, game fails to dispose) about minimap HOT 5 CLOSED

terasology commented on September 17, 2024

Incompatibility with Throughout the Ages (crashes, game fails to dispose)

from minimap.

Comments (5)

Cervator commented on September 17, 2024

Hi @Zireael07 - could you please post the full error message?

Oddly, it works fine for me - Omega 462 with Core + Minimap, nothing else. Did you have any other modules enabled?

I'm sorry I missed you on IRC but saw your comments in the log later. I wonder if something on your system is causing more than just performance issues? Sounds like you've got a laptop (the Radeon 6630M mention) which often encounter graphic issues not normally seen on desktops.

from minimap.

Zireael07 commented on September 17, 2024

I tried to use the minimap with Throughtout the Ages, as it's supposed to be 'the most complete experience'. Maybe they don't mesh with each other? Although I'd expect the minimap/HUD code to be module-independent...

No graphic issues, just CPU spikes regardless of dev/stable and/or modules loaded, and yes it's a laptop.

from minimap.

Cervator commented on September 17, 2024

Alright, as expected I can confirm this - although it may be more of a TTA issue or overall issue related to world generation and imaging the results. I suspect we can link this to MovingBlocks/Terasology#1524 as similar crashes occur when you try to preview a TTA map.

I'll rename this issue and leave it around till we figure out TTA to where we're actually sure it is implemented correctly as per latest architecture. Then likely Minimap for it will work well again.

Maybe there would be something we could consider to harden this module against such crashes. We did similar stuff for map previewing in the past.

Maybe worth noting that the crash didn't dispose the game and the high CPU usage is indicative of the chunk generator threads still running. One maybe similar example would be MovingBlocks/Terasology#1775 along with MovingBlocks/Terasology#1296 for general relevance.

Edit: Actual exception:

00:22:40.971 [main] ERROR o.terasology.engine.TerasologyEngine - Uncaught exception, attempting clean game shutdown
java.lang.NullPointerException: null
    at org.terasology.minimap.rendering.nui.layers.MinimapGrid.onDraw(MinimapGrid.java:192)
    at org.terasology.rendering.nui.internal.CanvasImpl.drawStyledWidget(CanvasImpl.java:406)
    at org.terasology.rendering.nui.internal.CanvasImpl.drawWidget(CanvasImpl.java:392)
    at org.terasology.rendering.nui.layouts.ColumnLayout.onDraw(ColumnLayout.java:186)
    at org.terasology.rendering.nui.internal.CanvasImpl.drawStyledWidget(CanvasImpl.java:406)
    at org.terasology.rendering.nui.internal.CanvasImpl.drawWidget(CanvasImpl.java:392)
    at org.terasology.rendering.nui.layouts.relative.RelativeLayout.onDraw(RelativeLayout.java:78)
    at org.terasology.rendering.nui.internal.CanvasImpl.drawStyledWidget(CanvasImpl.java:406)
    at org.terasology.rendering.nui.internal.CanvasImpl.drawWidget(CanvasImpl.java:392)
    at org.terasology.rendering.nui.layers.hud.CoreHudWidget.onDraw(CoreHudWidget.java:60)
    at org.terasology.rendering.nui.internal.CanvasImpl.drawStyledWidget(CanvasImpl.java:406)
    at org.terasology.rendering.nui.internal.CanvasImpl.drawWidget(CanvasImpl.java:392)
    at org.terasology.rendering.nui.layers.hud.HUDScreenLayer.onDraw(HUDScreenLayer.java:162)
    at org.terasology.rendering.nui.internal.CanvasImpl.drawStyledWidget(CanvasImpl.java:406)
    at org.terasology.rendering.nui.internal.CanvasImpl.drawWidget(CanvasImpl.java:392)
    at org.terasology.rendering.nui.internal.NUIManagerInternal.render(NUIManagerInternal.java:468)
    at org.terasology.engine.modes.StateLoading.render(StateLoading.java:259)
    at org.terasology.engine.subsystem.lwjgl.LwjglGraphics.postUpdate(LwjglGraphics.java:189)
    at org.terasology.engine.TerasologyEngine.mainLoop(TerasologyEngine.java:423)
    at org.terasology.engine.TerasologyEngine.run(TerasologyEngine.java:369)
    at org.terasology.engine.Terasology.main(Terasology.java:150)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:497)
    at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)
00:22:40.971 [main] INFO  o.terasology.engine.TerasologyEngine - Shutting down Terasology...

from minimap.

jdrueckert commented on September 17, 2024

@skaldarnar @Cervator as TTA is more or less dead and will probably only be plundered for things to take out into other or new modules, should we close this?

from minimap.

Cervator commented on September 17, 2024

IMHO I don't think so - whatever TTA did to crash Minimap is (probably?) still a live bug. Minimap should be hardened against that whether we have any modules actively trying to crash it or not :-)

Being that it has been so long, however, it could have been accidentally fixed in the meantime. Might be hard to even figure out since TTA itself likely doesn't run anymore 🤔

So with that in mind it may make sense to close this anyway letting the odds decide whether it gets seen and fixed at some point in the future or just disappears under the march of time.

from minimap.

Incompatibility with Throughout the Ages (crashes, game fails to dispose) about minimap HOT 5 CLOSED

Comments (5)

Related Issues (5)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent