Comments (5)
@Cervator: I can't seem to able to replicate any of the issues you mentioned. I've looked at the code and tested it out and the page turning appears to work as expected. The current page resets on close and there's no crash of any sort when leaving one book on the last page and opening another.
I also didn't face the issue where the click sound was played, but the bookcase didn't open. Instead, I'm actually facing the issue where e
clicks are getting eaten up. I suspect this is related to Terasology/JoshariasSurvival#15 as well...
As with chests, a reliable way of replicating this issue is opening the bookcase and then closing it using Esc
. First click does nothing, then the second click opens it.
How strange... I'm very curious as to what changes were made that caused this issue to resurface since you mentioned that you managed to fix this issue before. I'll try to look into this.
from books.
Oh I just noticed @Waterpicker submitted another commit 3 days after I entered that issue. So if it is fixed then cool! That's one item out of the way :-)
I think the click eating issue has two sides to it
- The actual issue around screens not closing correctly so the next
e
click is consumed. That's a bug we need to fix - You can configure UIs to where they aggravate/minimize the issue. That could be as simple as opening it a different way, like right click or
i
click instead ofe
clicking a block, leaving the player more likely to close the UI "correctly" in some way that avoids the issue
from books.
@Cervator Just saw your comment right after I submitted a PR for it in the main repo 🙂. This should mean that all the issues here are fixed.
from books.
Awesome, thanks! Checking back in later, leaving the house for a while now
from books.
Closing as complete :-)
from books.
Related Issues (13)
- Bookcases only get special logic on an authority client
- Recipes do not display correctly in RecipeBook
- Integration with Quests
- New book type: contract book
- Integration with JoshariasSurvival - recipe to create a book
- Remove dependency on CoreAssets
- UI Improvement
- Cursor can be left in the opening cover when page 1 is visible HOT 4
- Remove usage of default font HOT 1
- Re-implement some unique functionality for bookcases HOT 2
- Improve book pagination
- Support images in books HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from books.