Giter Club home page Giter Club logo

Comments (5)

iojw avatar iojw commented on July 17, 2024

@Cervator: I can't seem to able to replicate any of the issues you mentioned. I've looked at the code and tested it out and the page turning appears to work as expected. The current page resets on close and there's no crash of any sort when leaving one book on the last page and opening another.

I also didn't face the issue where the click sound was played, but the bookcase didn't open. Instead, I'm actually facing the issue where e clicks are getting eaten up. I suspect this is related to Terasology/JoshariasSurvival#15 as well...

As with chests, a reliable way of replicating this issue is opening the bookcase and then closing it using Esc. First click does nothing, then the second click opens it.

How strange... I'm very curious as to what changes were made that caused this issue to resurface since you mentioned that you managed to fix this issue before. I'll try to look into this.

from books.

Cervator avatar Cervator commented on July 17, 2024

Oh I just noticed @Waterpicker submitted another commit 3 days after I entered that issue. So if it is fixed then cool! That's one item out of the way :-)

I think the click eating issue has two sides to it

  • The actual issue around screens not closing correctly so the next e click is consumed. That's a bug we need to fix
  • You can configure UIs to where they aggravate/minimize the issue. That could be as simple as opening it a different way, like right click or i click instead of e clicking a block, leaving the player more likely to close the UI "correctly" in some way that avoids the issue

from books.

iojw avatar iojw commented on July 17, 2024

@Cervator Just saw your comment right after I submitted a PR for it in the main repo 🙂. This should mean that all the issues here are fixed.

from books.

Cervator avatar Cervator commented on July 17, 2024

Awesome, thanks! Checking back in later, leaving the house for a while now

from books.

Cervator avatar Cervator commented on July 17, 2024

Closing as complete :-)

from books.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.