Comments (3)
Hrm. Both if those should likely be deltas as apposed to overrides. I'll
fix tomorrow morning. Thanks for finding this bug, Cervator.
The empty shell is there so that both can extend the entity and not have
competing overrides like we have now.
On Sat, May 2, 2015, 9:31 PM Rasmus Praestholm [email protected]
wrote:
@Josharias https://github.com/Josharias this one might be for you, or
maybe @MarcinSc https://github.com/MarcinSc has an idea how to sort it
outAfter the recent module reorganization / extraction the leaf overrides in
WoodAndStone are targeting PlantPack, but so are new overrides in
AnotherWorldPlants. And the original prefab being overridden is now blank
where it seems it could retain the PartOfTree piece - although I'm unsure.In any case it would appear the override in AnotherWorldPlants is winning,
which only sets the PartOfTree, not the BlockDropGrammar - the override in
WoodAndStone does that. As a result no twigs are dropping, so progress in
TTA is blocked pretty quickSpecific example:
- Previous origin:
https://github.com/Terasology/PlantPack/blob/master/assets/prefabs/tree/birch/BirchLeaf.prefab- now empty, but still there
- Old override:
https://github.com/Terasology/WoodAndStone/blob/master/overrides/PlantPack/prefabs/tree/birch/BirchLeaf.prefab- still there, unchanged, still points at PlantPack
- New override:
https://github.com/Terasology/AnotherWorldPlants/blob/master/overrides/PlantPack/prefabs/tree/birch/BirchLeaf.prefab- takes precedence and doesn't contain BlockDropGrammar
I don't remember what the objective was, but I figure it was to keep
things better organized. But it puzzles me that only part of the assets
from PlantPack moved, leaving an empty shell behind.Incidentally I tried redirecting the override in WoodAndStone to instead
override AnotherWorldPlants, but it doesn't look like it worked.If at all either of you find a few minutes tonight to look at this please
do, as it is overwise a block for the release I'm trying to do tomorrow :-)
If not I'll just try best effort to fix it for the release then we can
re-break to refactor further.In the tree, part of the tree - wonder if animated gifs work!
[image: inthetreepartofthetree]
https://cloud.githubusercontent.com/assets/1063833/7443663/b02d475a-f12b-11e4-8d0b-fe53c2509e4c.gif—
Reply to this email directly or view it on GitHub
#35.
from woodandstone.
Thanks :-)
I'll work on the launcher and write-ups in the meantime
from woodandstone.
Closing as fixed! Thanks @Josharias :-)
from woodandstone.
Related Issues (19)
- [Icons] Meals/Ingredients HOT 1
- Item icon is removed when processed HOT 1
- Journal entry about clay/hearth/bricks HOT 1
- Sound effects HOT 1
- Quern build stages HOT 2
- New Journal Chapter Icons HOT 1
- Add missing UI backgrounds and unify naming HOT 1
- NPE on Stone Workstation upgrade HOT 3
- Crash bug with two tools in upgraded wood workstation HOT 8
- Using workbench only allows one material construction per table. HOT 4
- Quirks in world gen after faceted overhaul HOT 3
- Minor compile error due to NameGenerator change HOT 2
- Better clarification that "blocks" don't typically drop HOT 8
- Planting CornSeed causes java.lang.RuntimeException: component null HOT 2
- Extract `org.terasology.herbalism` to separate module named "Herbalism" HOT 1
- Extract `org.terasology.mill` in separate module HOT 1
- Extract `org.terasology.heat` in separate module HOT 1
- Update Journal entries to new icons/tools HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from woodandstone.