Giter Club home page Giter Club logo

Comments (7)

MoonBow-1 avatar MoonBow-1 commented on August 18, 2024

Found out that this bug was introduced in commit 843c990a, going to investigate the reason

from cfe_31.

MoonBow-1 avatar MoonBow-1 commented on August 18, 2024

Problem is the location of the CaptureMeta send method inside the GenerateFiles.
If the Meta is sent right after constructing it in the generateFiles, it will result in duplicate names in CFE-18.
If this is done in a for-each loop in the send method of the GenerateFile, this will result in much less errors from CFE-18.

Doesn't work properly:

            final CaptureMeta captureMeta = captureDefinitionEntry.getCaptureMeta(this);
            captureMeta.generateNewNameForDuplicateCaptureMeta(captureMetaSet);

            captureMetaSet.add(captureMeta);
            captureMeta.send();

from cfe_31.

MoonBow-1 avatar MoonBow-1 commented on August 18, 2024

The breaking changes were rolled back up to commit 85e50f70.
This will require more refactoring to get it working somehow.

Maybe the CaptureMetaMap is still a viable option, and in the sendAll method, get the required CaptureMeta for the CaptureDefinition by the processingType field, send the captureMeta --> construct a new CaptureDefinition with the new processingType response from CFE-18.

from cfe_31.

MoonBow-1 avatar MoonBow-1 commented on August 18, 2024

Maybe the CaptureMetaMap is still a viable option, and in the sendAll method, get the required CaptureMeta for the CaptureDefinition by the processingType field, send the captureMeta --> construct a new CaptureDefinition with the new processingType response from CFE-18.

This has been implemented/fixed in commit 6fb22645.

There are some captureMeta errors still showing up, but these are pretty rare --> investigating

from cfe_31.

MoonBow-1 avatar MoonBow-1 commented on August 18, 2024

Looked at this issue today, moved the CaptureMetaMap to be passed from main, so it persists between different dirs.
CFE-18 still has some issues, so will be continuing on this tomorrow.

from cfe_31.

MoonBow-1 avatar MoonBow-1 commented on August 18, 2024

There we some changes on CFE-18, where it doesn't accept CaptureMetas with the same name.

Problem: CaptureMetas are sent every time before Captures, resulting in errors.
Solution: implement a Set of already sent CaptureMetas to not send duplicates.

Implemented in commit 863ae879

from cfe_31.

MoonBow-1 avatar MoonBow-1 commented on August 18, 2024

Implemented a fix on commit 2535b514, where the CaptureMetaMap's generateNewName method bypassed its own put and putIfAbsent methods, and used the Map's own those, resulting in the name field being populated in the Map's values.

captureMetaMap.put(captureMeta.getName(), new CaptureMeta());

fixed to:

put(captureMeta);

Old version: 352 CaptureMetas, of which ~250 sent
New version: 151 captureMetas, of which 116 sent

from cfe_31.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.