Exception handling about hangar-py HOT 6 CLOSED

ok. all these changes are merged in #16

from hangar-py.

@hhsecond i'll leave it to you to close this issue when you feel it is appropriate. It's good for me right now.

from hangar-py.

Hey @rlizzo, Have you got a chance to run through this? As far as I could think, raising an exception in all the cases (even for minor issues) is the best we could do unless we don't want to put the whole stack trace onto user's CLI (we could still use exception hooks to suppress those messages if we want). Or do you have some other reasons to use the bool return instead of raising exceptions that I might be missing?

from hangar-py.

Hey @hhsecond, sorry I needed a few days to really think about this.

I think you're completely right. We should be just raising exceptions for this. I'd like to stick to the Python standard library exception classes for now. As far as the stack traces go, they might print alot to the screen, but I think it's OK for now (if anything it'll help us debug any user bug reports); getting pretteir tracebacks is a problem for another time. If we just log to error to the console before raising the exception, it should be OK for now - we just need to have fairly informative error messages.

I'm putting together a PR for this right now, should be merged before I go to bed tonight. sorry if this was holding you up at all!

from hangar-py.

Hey @rlizzo, no worries and thanks a lot for taking this for me. I even had started this in a separate branch but then thought of discussing with you about the design. I am keeping this issue opened at least until I finish both local and remote testing. I'll open more PRs if required in the future given that now I know what should be the way forward for exceptions.

from hangar-py.

Closing due to inactivity

from hangar-py.