Comments (3)
Interesting. Issues and Pull Requests are in the same namespace (as you probably know). For whatever reason, the API seems to label them both as issues. For example I made a comment yesterday: rails-api/active_model_serializers/pull/1426#issuecomment-221940036
and in the GitHub API firehose, that event was labeled as an IssueCommentEvent
. That does seem like a bug to me, but in the GitHub API.
from opensourcecontributors.
For most issue
-type objects in the Github API, there is a pull_request
key in the object if it is a pull request (see https://developer.github.com/v3/issues/ ). IssueCommentEvents
include the issue
object - is the pull_request
key included here?
from opensourcecontributors.
curl -L http://data.githubarchive.org/2016-05-28-1.json.gz | zcat | grep IssueCommentEvent | grep pulls | head -n5 | jq .
Indeed it is!
from opensourcecontributors.
Related Issues (20)
- Use event_id as ID where possible HOT 3
- Upstream prematurely closed connection HOT 2
- Account for nginx in ghc-app logs
- Middleware to filter out misleading panics HOT 1
- Handle errors in which the server is down
- Mobile rendering terrible HOT 3
- Aggregate digest tool for hourly data
- Replaces email notifications with Rollbar HOT 1
- Sitemap
- Clean up Python cobwebs HOT 1
- Use "net/context" HOT 1
- Rollbar - use "trace" instead of "message" HOT 2
- Tests
- JSON API? HOT 4
- Distinguish forks and main repositories
- Provide data in json via very simple API, suitable for further analysis by the users HOT 5
- Link to json format api endpoints from search query results
- Site and API down? HOT 7
- Trying to get in touch regarding a security issue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opensourcecontributors.