Giter Club home page Giter Club logo

Comments (3)

hut8 avatar hut8 commented on September 22, 2024

Interesting. Issues and Pull Requests are in the same namespace (as you probably know). For whatever reason, the API seems to label them both as issues. For example I made a comment yesterday: rails-api/active_model_serializers/pull/1426#issuecomment-221940036 and in the GitHub API firehose, that event was labeled as an IssueCommentEvent. That does seem like a bug to me, but in the GitHub API.

from opensourcecontributors.

joshjordan avatar joshjordan commented on September 22, 2024

For most issue-type objects in the Github API, there is a pull_request key in the object if it is a pull request (see https://developer.github.com/v3/issues/ ). IssueCommentEvents include the issue object - is the pull_request key included here?

from opensourcecontributors.

hut8 avatar hut8 commented on September 22, 2024
curl -L http://data.githubarchive.org/2016-05-28-1.json.gz | zcat | grep IssueCommentEvent | grep pulls | head -n5 | jq .

Indeed it is!

from opensourcecontributors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.