Giter Club home page Giter Club logo

Comments (4)

TelepathicGrunt avatar TelepathicGrunt commented on June 30, 2024

the island isn’t isn’t the issue. It’s the fact that the land structure is spawning in an ocean biome.

Aren’t you using fabric/quilt? Because c:icy tag has frozen ocean in it which I have a PR up to fix on fabric. So this isn’t a forge issue unless someone else or another mod is adding frozen ocean to c:icy or forge:is_icy tags FabricMC/fabric#2416 (review)

With a datapack, delete this entry by making the datapack’s icy tag have replace as true and copy the other entries without c:icy
https://github.com/TelepathicGrunt/RepurposedStructures/blob/00094cb8b2d62952658b3fbd24d0a109cbd18153/src/main/resources/data/repurposed_structures/tags/worldgen/biome/collections/icy.json#L14

I already fixed this issue in 1.19 by removing c:icy tag from my biome tag that I use for my structures until the fabric pr is merged.

Forge doesn’t have a forge:is_icy tag so no oceans are being pulled in there. Byg’s byg:icy tag has byg:shattered_glacier which is a land biome iirc.

from repurposedstructures-quilt.

sisby-folk avatar sisby-folk commented on June 30, 2024

from repurposedstructures-quilt.

TelepathicGrunt avatar TelepathicGrunt commented on June 30, 2024

I'll keep this open until fabric merges my PR just so the issue is documented and others can see. I'll also perform magic and move this over to the Quilt repo.

from repurposedstructures-quilt.

TelepathicGrunt avatar TelepathicGrunt commented on June 30, 2024

fabric api just merged the icy tag change into their 1.19.2 version to not include water biomes

from repurposedstructures-quilt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.