Giter Club home page Giter Club logo

Comments (4)

TheEpicBlock avatar TheEpicBlock commented on June 12, 2024

https://github.com/TelepathicGrunt/Bumblezone-Fabric/blob/8503fd7a9c53d03ab066940baf45e93c843c66a0/src/main/java/net/telepathicgrunt/bumblezone/entities/PlayerTeleportation.java#L156
Found it being used here too. The translation key or id for the block should probably be used here

from bumblezone-quilt.

TelepathicGrunt avatar TelepathicGrunt commented on June 12, 2024

Funny story about that lol. In forge (where I made Bumblezone originally for), blocks have a way to get their registry name directly from the block itself due to a Forge patch. In fabric, I didn’t realize this and thought .getName/getLoottableName was the yarn names when it wasn’t. I went to fix that up so it gets registry names again but it seems I missed that one in the sugar water feature. I’ll fix that in about two hours when I can get to my laptop. It’s not suppose to use translatable names as the en_us.json file doesn’t exist on the server which is why I opted to check a block’s registry name to see if they have honeycomb in the name for better mod compat. (I would do tags but that would require me to find every possible mod with honeycombs and they might not even have bees in the name making it impossible to find them)

The second one in player teleportation is actually intentional and shouldn’t crash the server (tested on server locally) because of the player.isClient check. That prevents the server from executing the several client code in that if statement that sends an error message to the player.

from bumblezone-quilt.

TelepathicGrunt avatar TelepathicGrunt commented on June 12, 2024

But yeah, thank you for bringing this to my attention! Next update should fix that sugar water issue

from bumblezone-quilt.

TelepathicGrunt avatar TelepathicGrunt commented on June 12, 2024

Ah shoot. the Player teleportation one was also broken as the code never got executed due to the checks lmao. Both of these are fixed in 2.1.2 so try that out.

Thank you for reporting the issue!

from bumblezone-quilt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.