Comments (12)
@avinal Let's continue our discussion here regarding broken cel filter.
from results.
Note: this particular expression was working before a few updates. I am unable to pinpoint where it changed. Furthermore, only this expression is failing. All other filters I tested work fine. Somehow, the summary.status
field is interpreted as int.
from results.
The issue might not be with the tkn-results
, then. It might be with CEL-related changes in API.
from results.
These are the two PRs that we need to test for this error by running -1 commit:
#544
#495
from results.
I would also widen the subject from just tkn-results
to REST and gRPC as well, I checked, it doesn't work there either. Yes this seems to be a CEL change.
from results.
/assign
from results.
Yes, the summary.status is an integer because it is declared like this in the proto definition and mapped to an integer in the database. When I redesigned the search mechanism to support an interpreter from CEL to SQL, one of the things that I tried to do was preserving the types that people see when viewing the wire types in the search. I believe that this reduces cognitive load and the continuous mental mapping between things - if the summary.status is an integer I don't need to remember of referencing it as a string when searching.
In addition, there're a few constants to help people to reference the enum values instead of using the numeric values (the constants are the string representation of the enums in the proto format). Could you try the following instead?
./tkn-results list default --filter="summary.status==SUCCESS"
from results.
@alan-ghelardi that makes sense. I tested it and it works fine without strings. I will close this issue and update this detail in docs. Thank You
from results.
/close
from results.
@avinal: You can't close an active issue/PR unless you authored it or you are a collaborator.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from results.
I must have messed up while testing and used quotes. I have added a clear paragraph to avoid this mistake by others.
from results.
/close Fixed
from results.
Related Issues (20)
- Integration of Knative Adapter for Enhanced Logging in Tekton Results API HOT 3
- Persist TaskRun logs with timestamps (opt-in) HOT 1
- Expose Watcher configuration through configMap HOT 2
- Problem with how `result.summary.status` gets set
- TaskRuns gets deleted before PipelineRun completes if check_owner flag is disabled
- Document Pruning Behavior HOT 1
- Memory consumption of the watcher container keeps increasing over time
- log processing was not handling runs that have been cancelled
- prototype and document how to run multiple replicas of the api server HOT 2
- Storing logs fails with `operation error S3: UploadPart, https response error StatusCode: 404 ... api error NoSuchUpload: UnknownError` HOT 4
- UpdateLog calls from watcher intermittently fail with canceled context; no UpdateLog call error from watcher are re-reconciled
- Results and Record annotations are missing when summary annotation is used. HOT 4
- Startup Probes fails in Disconnected/Proxy Install of Kubernetes/OpenShift, HOT 5
- Watcher stores PipelineRun YAML without taskRunTemplate, podTemplate and env vars HOT 9
- Document Tekton results release strategy in a `release.md` file
- Running Replica of results API server to communicate with watcher without RBAC
- log storage feature needs to be rewritten HOT 4
- Tests are failing on the main branch
- Need some indication of taskruns never leaving pending state before timeouts HOT 1
- How to use results (e.g. minio or aws s3) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from results.