Comments (2)
The issue here is that both the Results API and k8s object names approximately follow RFC 1123, which has a max length of of 63 chars. If we want to support <type>-<name>
syntax, we'll need to either bump the max allowed length to 127 (63+1+63) or use a different strategy for selecting default names.
from results.
Few options I'm considering at the moment:
- Use object UIDs. This has the benefit of dealing with delete + apply iterations gracefully, but loses out on human recognizable names.
- Drop the type prefix, and only use the name. Since k8s resource names will be <= 63 chars, this will make it compatible with the current results constraints, but this means that we can't distinguish taskruns from pipelineruns, so if a pair of objects share the same name they will be automatically grouped in the same result by default (which might be unintended in some cases).
- Expand the constraints to allow for type + name. While this would allow us to keep the same semantics as we have right now, this means that names could potentially be up to 63+len('/results/')+127+len('/records/')+127 = 335, which seems excessive.
from results.
Related Issues (20)
- Handle panics in API server
- Epic: resolve bugs related to CEL filtering and add missing filters
- Result Summary startTime is null HOT 2
- Enable prometheus histogram metrics for API server
- API OpenAPI spec for Log data is of incorrect type HOT 3
- Error reading preface error in the tekton results api controller logs in the Openshift with enabled http/2 HOT 2
- Individual log is not retrievable via the name returned in the log list HOT 6
- `exists` filters is missing HOT 3
- Liveness and Readiness probes fail with recommended certificate setup HOT 23
- Postgres STS fails to start - mkdir: cannot create directory β/bitnami/postgresql/dataβ HOT 7
- Tekton Results CLI release
- Update release pipelines for attestation HOT 1
- v1 Release of Results HOT 3
- Database SSL Mode `verify-ca` or `verify-full` with a custom CA certificate HOT 2
- OpenAPI misleading `UID` description about `Result`API HOT 10
- Step level log HOT 9
- Filter by labels and namespace in querying results HOT 2
- Improve docs on compiling proto files and setting up the dev env HOT 1
- Improve log messages and log configurations HOT 1
- move `tkn-results` to the same tree as the results package HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from results.