Giter Club home page Giter Club logo

Comments (2)

wlynch avatar wlynch commented on July 21, 2024

The issue here is that both the Results API and k8s object names approximately follow RFC 1123, which has a max length of of 63 chars. If we want to support <type>-<name> syntax, we'll need to either bump the max allowed length to 127 (63+1+63) or use a different strategy for selecting default names.

from results.

wlynch avatar wlynch commented on July 21, 2024

Few options I'm considering at the moment:

  1. Use object UIDs. This has the benefit of dealing with delete + apply iterations gracefully, but loses out on human recognizable names.
  2. Drop the type prefix, and only use the name. Since k8s resource names will be <= 63 chars, this will make it compatible with the current results constraints, but this means that we can't distinguish taskruns from pipelineruns, so if a pair of objects share the same name they will be automatically grouped in the same result by default (which might be unintended in some cases).
  3. Expand the constraints to allow for type + name. While this would allow us to keep the same semantics as we have right now, this means that names could potentially be up to 63+len('/results/')+127+len('/records/')+127 = 335, which seems excessive.

from results.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.