Watcher failed to update Record when metadata.generation is not changed about results HOT 9 CLOSED

/priority important-soon

from results.

i got the same problem. is there any idea to resove ?

from results.

We were able to solve this issue by removing this conditional in watcher/results/results.go 167 and the watcher was able to update the records.

if o.GetGeneration() != 0 && o.GetGeneration() == u.GetGeneration() {
	// The record data already matches what's stored. Don't update
	// since this will rev update times which throws off resource
	// cleanup checks.
	return curr, nil
}

But I don't think that's a permanent solution and it may cause problems in the future.

from results.

The intent behind this was to only update when there's a change to the data. If this isn't capturing all cases, we can do something more involved like a cmp.Equal or something similar.

Anyone happen to have a reference as to when generation increments?

from results.

I fount this link: https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/
The .metadata.generation value is incremented for all changes, except for changes to .metadata or .status.

So as I mentioned in the question, if the pipelinerun's status changes from Pending to Succeeded, record won't be updated.

from results.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

from results.

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

from results.

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

from results.

@tekton-robot: Closing this issue.

from results.