Giter Club home page Giter Club logo

Comments (9)

TehShrike avatar TehShrike commented on August 15, 2024 2

I confirmed that it works with that change to login's route in state-router-example.

Thanks for reporting! 👍

from abstract-state-router.

TehShrike avatar TehShrike commented on August 15, 2024

Is the evaluateCurrent line updated?

Is the router emitting a routeNotFound event?

What is the url when you refresh? If you wipe out the hash fragment and refresh, does it behave differently?

from abstract-state-router.

rob-balfre avatar rob-balfre commented on August 15, 2024

evaluateCurrent is pointing to 'login'. routeNotFound is not being fired. If I manually remove the hash from the url and refresh it works.

from abstract-state-router.

rob-balfre avatar rob-balfre commented on August 15, 2024

It's pretty easy to recreate, just update this line to point to '/'

from abstract-state-router.

TehShrike avatar TehShrike commented on August 15, 2024

from abstract-state-router.

TehShrike avatar TehShrike commented on August 15, 2024

mm, I was able to reproduce. It looks like evaluateCurrentRoute doesn't have any effect when the url is / and the default state that you're giving it has a route of /. No events fired or anything. I'll make a unit test.

from abstract-state-router.

TehShrike avatar TehShrike commented on August 15, 2024

It's a bug in hash-brown-router :-o

from abstract-state-router.

TehShrike avatar TehShrike commented on August 15, 2024

Published as 6.0.4.

from abstract-state-router.

rob-balfre avatar rob-balfre commented on August 15, 2024

@TehShrike awesome thanks

from abstract-state-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.