Giter Club home page Giter Club logo

Comments (4)

danisyellis avatar danisyellis commented on June 11, 2024 1

Before starting this, I tested the code as it currently is.
I saw that
a) you say that "The UI should behave the same as the live site" but when testing the site after using npm startor npm run dev, the app doesn't give the "you were slower..." or "you were faster..." info like the live site does. Basically, everything works the same, but the wording is a little different.
b) running npm start:prod fails with this error: Error: Dialect needs to be explicitly supplied as of v4.0.0 at new Sequelize

I'm assuming these things are what's expected from this repo and tested the dependabot PRs with the intention to only flag problems if I saw any different behavior.
I tested all 5 dependabot PRs currently in the repo and didn't see any other issues, so I've approved each of them.

Last note: when I test dependabot PRs for my own repo, I test each one individually, merge it in, and then test the next, on the offchance that one affects the next. In this case, since I've verified them individually, and none of them are major version changes, I think they can all be merged in at once. But then there should be one last verification once they're all in!

I think you've made me a maintainer on the keyboard shortcuts repo, so if you want, I can do the merging and final verification. I just wanted to check my assumptions above before doing that.

I hope getting these version bumps verified makes it easier to work on any other issues or features you're hoping to get done :-)

from curriculum.

stale avatar stale commented on June 11, 2024

Although it may very well be a good idea, this issue has not had recent activity and is unlikely to be worked on. Consider creating your own pull request for the issue if that is feasible. If no further activity occurs, this will be closed in 14 days. Thank you for your contribution.

from curriculum.

alodahl avatar alodahl commented on June 11, 2024

Thanks Dani! I'm fine with you merging things in yourself. I think that I may have messed things up as I was trying to merge "backend" into main today, so sorry if I did.

from curriculum.

alodahl avatar alodahl commented on June 11, 2024

If you'd like to make a tiny PR that just fixes a typo somewhere, I can approve it so this counts for Hacktoberfest

from curriculum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.