How to type function signatures about giessdenkiez-de HOT 8 CLOSED

Signature typing

I think that both ways are valid but I prefer the tightly coupled way because:

1. It doesn't contain the => twice, making the readability better (we avoid confusing the signature for the real function)
2. It shares the way of typing it with functions written with the function keyword

If you wish to share signatures between multiple functions, prefer using a type. That makes its reusability explicit:

type ClickHandleSignature = (id: string) => void

const onClickHandler: ClickHandlerSignature = (id) => {
  // ...
}

I prefer not to makes things generic until really necessary. It is way simpler to refactor.

Function keyword

I don't use the function keyword in most cases for a few reasons:

1. It is less verbose and can return without a return keyword, making it easy to write composable on-liners
2. It makes it explicit that the this keyword isn't used here. You don't even think about it. Wit a function that has a function keyword, you never know.

from giessdenkiez-de.

It doesn't contain the => twice, making the readability better (we avoid confusing the signature for the real function)

Funny I find your way harder to digest then the one I prefer. :)

from giessdenkiez-de.

If you wish to share signatures between multiple functions, prefer using a type. That makes its reusability explicit:

That's what I said. :)

I prefer not to makes things generic until really necessary. It is way simpler to refactor.

Me too. But if I have to my way is faster 🚀

from giessdenkiez-de.

Funny I find your way harder to digest than the one I prefer. :)

Common, could we not talk about your way/ my way? An can you elaborate on why do you think it is easier to digest?

from giessdenkiez-de.

That's what I said. :)

Your suggestion included the signature as a prefix to the parameters, which as I said, has to risk to make the readability of the function more difficult as it contains two =>. The developer has to first identify which is the signature and which is the function declaration.

In my suggestion, the signature is external to the function declaration. I would only use that in the case it really is used multiple time.

from giessdenkiez-de.

Me too. But if I have to my way is faster 🚀

Coding with speed is only good if it doesn't compromise the readability of the code. But sure, you might save some milliseconds.

from giessdenkiez-de.

Let's move that to discussions.

from giessdenkiez-de.

Let's keep on in #297

from giessdenkiez-de.