Feature Request: Add a Docker Environment Variable for the Web Server Listening Address about dnsserver HOT 20 CLOSED

Thanks for the request. Will get the environment variable added in the upcoming update.

from dnsserver.

How is your release schedule? I'd like to know when I should check back.

The next update is planned for upcoming weekend but it may get a bit delayed too. I will post here when its available so that you are notified.

from dnsserver.

Doing a code search for how this text field is handled...

Element ID: txtWebServiceLocalAddresses

That element gets sanitized for saving here:

relevant HTTP request:

and it is retrieved here:

relevant HTTP request:

from dnsserver.

Settings API source code:

https://github.com/TechnitiumSoftware/DnsServer/blob/master/DnsServerCore/WebServiceSettingsApi.cs

from dnsserver.

Relevant lines for setting the web addresss:

Note this line from the above blob:

The restart of the server (and the application of the new listening address), starts here:

https://github.com/TechnitiumSoftware/DnsServer/blob/master/DnsServerCore/WebServiceSettingsApi.cs#L1344

from dnsserver.

It is appears that while running, the webserver uses _dnsWebService._webServiceLocalAddresses for storing the listening address

The class for this is defined here:

https://github.com/TechnitiumSoftware/DnsServer/blob/master/DnsServerCore/DnsWebService.cs

Here is the property:

from dnsserver.

This appears to be where the config is read from:

Which is wrapped by this method:

Which is called by this method:

Which loads the config file with this snippet:

from dnsserver.

Config file (for the DnsWebService class) appears to be defined here on Linux:

Which is pulled from the arguments passed to the executable:

Which for docker, is defined in the service file:

from dnsserver.

Next thing I need to do is to determine if I can even interact with that binary file (dns.config). When I try to cat it on ubuntu, I got a bunch of garbage in the output, so it does not appear to be plain text

from dnsserver.

Looks like it should be easy to set it with the LoadConfigFile() method:

You would just have to transpile the sanitization scripts and place them in the above blob

frontend:

backend:

from dnsserver.

It looks like it might not even need to be that complicated, since cleanTextList just replaces newlines and removes additional commas

// Replace newlines with commas
string webServiceLocalAddresses = input.Replace("\n", ",")

// Replace duplicate commas with single commas
webServiceLocalAddresses = Regex.Replace(webServiceLocalAddresses, ",{2,}", ",");

// Trim the string of starting/trailing whitespace and commas
webServiceLocalAddresses = Regex.Replace(webServiceLocalAddresses, "(?:^[, ]+)|(?:[, ]+$)", ",");

// insert above snippet from DnsServerCore/WebServiceSettingsApi.cs (lines L703-L730)
// ...

I currently lack an environment to build and test on right now, but if someone thinks they can get a fork/PR spun up faster than me, please go for it. If not, I might have my lab back up and running by end of this week or next week.

from dnsserver.

How is your release schedule? I'd like to know when I should check back.

from dnsserver.

Technitium DNS Server v12.1 is now available that adds the environment variable. Do update and let me know your feedback.

from dnsserver.

Will do. Have inspections this weekend, so this will likely get implemented later this week

from dnsserver.

New environment variable (DNS_SERVER_WEB_SERVICE_LOCAL_ADDRESSES) will need to be added to the docker compose file.

Testing out the change now. Give me a bit

from dnsserver.

Works for singular listening address.

DNS_SERVER_WEB_SERVICE_LOCAL_ADDRESSES="172.18.0.1" # Single Docker bridge address

Rebuilding it for 2 addresses

DNS_SERVER_WEB_SERVICE_LOCAL_ADDRESSES="172.18.0.1, 172.17.0.1" # Multiple Docker bridge addresses, comma-delimited

I'm not entirely sure if the environment variables can handle line returns, but I don't see why anyone would use line returns over the comma-delimiter for this. So I won't test that.

from dnsserver.

It did not like the comma-delimited address

EDIT: also tried newlines with compose.yaml:

- DNS_SERVER_WEB_SERVICE_LOCAL_ADDRESSES=|
          172.18.0.1
          127.0.0.1 # also changed this just in case it didn't like the docker bridge adapter

Did not work, but newlines seem like a strange way to do this from yaml, so I would worry about the prior, but not the latter.

from dnsserver.

Here are the logs:

dns-dhcp-test  | System.FormatException: An invalid IP address was specified.
dns-dhcp-test  |  ---> System.Net.Sockets.SocketException (22): Invalid argument
dns-dhcp-test  |    --- End of inner exception stack trace ---
dns-dhcp-test  |    at System.Net.IPAddressParser.Parse(ReadOnlySpan`1 ipSpan, Boolean tryParse)
dns-dhcp-test  |    at TechnitiumLibrary.StringExtensions.Split[T](String value, Func`2 parse, Char[] separator) in Z:\Technitium\Projects\TechnitiumLibrary\TechnitiumLibrary\StringExtensions.cs:line 34
dns-dhcp-test  |    at DnsServerCore.DnsWebService.LoadConfigFile() in Z:\Technitium\Projects\DnsServer\DnsServerCore\DnsWebService.cs:line 898
dns-dhcp-test  |    at DnsServerCore.DnsWebService.StartAsync() in Z:\Technitium\Projects\DnsServer\DnsServerCore\DnsWebService.cs:line 2540
dns-dhcp-test  |    at TechnitiumLibrary.TaskExtensions.Sync(Task task) in Z:\Technitium\Projects\TechnitiumLibrary\TechnitiumLibrary\TaskExtensions.cs:line 56
dns-dhcp-test  |    at DnsServerCore.DnsWebService.Start() in Z:\Technitium\Projects\DnsServer\DnsServerCore\DnsWebService.cs:line 2668
dns-dhcp-test  |    at DnsServerApp.Program.Main(String[] args) in Z:\Technitium\Projects\DnsServer\DnsServerApp\Program.cs:line 55
dns-dhcp-test  | 
dns-dhcp-test  | Technitium DNS Server is stopping...
dns-dhcp-test  | Technitium DNS Server was stopped successfully.
dns-dhcp-test exited with code 0

from dnsserver.

Got it. The compose file did not like the quotes, so in YAML you can use:

- DNS_SERVER_WEB_SERVICE_LOCAL_ADDRESSES=172.18.0.1,127.0.0.1

Will be submitting a PR for the docker compose file

from dnsserver.

Thanks for the feedback and for the PR. Had missed updating the docker compose file to add it.

from dnsserver.